linux-kernel - Re: [PATCH] nvme-pci: Remove NVME_QUIRK_BOGUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z88aRU7Bq3SYtyyO@kbusch-mbp>
Date: Mon, 10 Mar 2025 10:58:45 -0600
From: Keith Busch <kbusch@...nel.org>
To: Jianlin Lv <iecedge@...il.com>
Cc: axboe@...nel.dk, hch@....de, sagi@...mberg.me,
	linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
	jianlv@...y.com
Subject: Re: [PATCH] nvme-pci: Remove NVME_QUIRK_BOGUS_NID for device vendors

On Sat, Mar 08, 2025 at 10:11:02PM +0800, Jianlin Lv wrote:
> After commit ac522fc6c316 ("nvme: don't reject probe due to duplicate IDs
> for single-ported PCIe devices") merged, vendors no longer need to use
> quirks in the PCI ID entry to work around the issue of duplicate IDs.
> The NVME_QUIRK_BOGUS_NID flag changes the format of device attribute file
> names under /dev/disk/by-id/.
> For example, /dev/disk/by-id/nvme-eui.xxx -> /dev/disk/by-id/nvme-nvme.xxx.
> 
> Considering that naming formats need to have high stability and
> recognizability, it is more prudent to make changes only for rare,
> sporadic cases rather than implementing comprehensive changes. Therefore,
> this patch remove default setting of NVME_QUIRK_BOGUS_NID flag for vendors,
> and the flag is added dynamically only when duplicate IDs is detected,
> as implemented in ac522fc6c3165f.

Setting the quirk on demand lets the first scanned namespace export the
"unique" identifiers as their own. Scanning isn't deterministic if you
have more than one, so you wouldn't readily know which actual namespace
a particular /dev/disk/by-id/ link points to.