linux-kernel - Re: [PATCH] block: add lock for safe nrpages access in invalidate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z88dOtsjiIUx6apV@casper.infradead.org>
Date: Mon, 10 Mar 2025 17:11:22 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Yuan Tan <tanyuan@...ylab.org>
Cc: axboe@...nel.dk, syzbot+f2aaf773187f5cae54f3@...kaller.appspotmail.com,
	linux-block@...r.kernel.org, akpm@...ux-foundation.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, syzkaller-bugs@...glegroups.com,
	falcon@...ylab.org
Subject: Re: [PATCH] block: add lock for safe nrpages access in
 invalidate_bdev()

On Mon, Mar 10, 2025 at 09:54:00AM -0700, Yuan Tan wrote:
> Syzbot reported a data-race in __filemap_add_folio / invalidate_bdev[1]
> due to concurrent access to mapping->nrpages.
> Adds a lock around the access to nrpages.

Did you even read my analysis?  This is a grossly inappropriate fix.
NAK.