linux-kernel - Re: [PATCH 2/2] regulator: assert that dummy regulator has been probed before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d195bf7-de99-4fe9-87b0-291e156f083c@sirena.org.uk>
Date: Mon, 10 Mar 2025 17:23:02 +0000
From: Mark Brown <broonie@...nel.org>
To: Christian Eggers <ceggers@...i.de>
Cc: Liam Girdwood <lgirdwood@...il.com>,
	Douglas Anderson <dianders@...omium.org>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 2/2] regulator: assert that dummy regulator has been
 probed before using it

On Mon, Mar 10, 2025 at 05:33:02PM +0100, Christian Eggers wrote:
> Due to asynchronous driver probing there is a chance that the dummy
> regulator hasn't already been probed when first accessing it.

>  		if (have_full_constraints()) {
>  			r = dummy_regulator_rdev;
> +			BUG_ON(!r);
>  			get_device(&r->dev);
>  		} else {
>  			dev_err(dev, "Failed to resolve %s-supply for %s\n",
> @@ -2086,6 +2087,7 @@ static int regulator_resolve_supply(struct regulator_dev *rdev)
>  			goto out;
>  		}
>  		r = dummy_regulator_rdev;
> +		BUG_ON(!r);

This doesn't actually help anything - I'd expect this to trigger probe
deferral.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)