linux-kernel - Re: [PATCH 2/2] crypto: lib/Kconfig: hide library options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250310172734.GE1701@sol.localdomain>
Date: Mon, 10 Mar 2025 10:27:34 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	"Justin M. Forbes" <jforbes@...oraproject.org>,
	"Jason A. Donenfeld" <Jason@...c4.com>,
	Arnd Bergmann <arnd@...db.de>, Ard Biesheuvel <ardb@...nel.org>,
	Jarkko Sakkinen <jarkko@...nel.org>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] crypto: lib/Kconfig: hide library options

On Mon, Mar 10, 2025 at 02:26:40PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Any driver that needs these library functions should already be selecting
> the corresponding Kconfig symbols, so there is no real point in making
> these visible.
> 
> The original patch that made these user selectable described problems
> with drivers failing to select the code they use, but as far as I can
> tell, those were all bugs that got solved in the meantime and did not
> get solved by that patch.
> 
> Fixes: e56e18985596 ("lib/crypto: add prompts back to crypto libraries")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ----
> This does not actually fix a build failure, but I noticed that the
> user visible options don't really make sense. Feel free to ignore
> this one.

Acked-by: Eric Biggers <ebiggers@...nel.org>

But I think the following needs to be fixed first:

    config BIG_KEYS
            bool "Large payload keys"
            depends on KEYS
            depends on TMPFS
            depends on CRYPTO_LIB_CHACHA20POLY1305 = y

- Eric