linux-kernel - Re: [PATCH net-next v9] net: mdio: Add RTL9300 MDIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z88sJSzFTmYMvsZL@shell.armlinux.org.uk>
Date: Mon, 10 Mar 2025 18:15:01 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Chris Packham <chris.packham@...iedtelesis.co.nz>, andrew@...n.ch,
	hkallweit1@...il.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, sander@...nheule.net,
	markus.stockhausen@....de, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v9] net: mdio: Add RTL9300 MDIO driver

On Mon, Mar 10, 2025 at 07:06:13PM +0100, Christophe JAILLET wrote:
> > +		err = of_property_read_u32(phy_dn, "reg", &addr);
> > +		if (err)
> > +			return err;
> > +
> > +		bitmap_set(priv->valid_ports, pn, 1);
> 
> set_bit(pn, priv->valid_ports) ?

If you don't need it to be atomic, then please use __set_bit().

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!