linux-kernel - Re: [PATCH v1 1/1] kbuild: Add "make headers" to "make help" output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6149ac51-07da-45e2-863e-1d4418f6b662@zytor.com>
Date: Sun, 9 Mar 2025 23:22:27 -0700
From: Xin Li <xin@...or.com>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
        nathan@...nel.org, nicolas@...sle.eu, bp@...en8.de, hpa@...or.com,
        sraithal@....com
Subject: Re: [PATCH v1 1/1] kbuild: Add "make headers" to "make help" output

On 3/8/2025 7:12 AM, Masahiro Yamada wrote:
> On Sat, Mar 8, 2025 at 1:05 PM Xin Li (Intel) <xin@...or.com> wrote:
>>
>> Meanwhile explicitly state that the headers are uapi headers.
> 
> There are many internal-use targets, which are not documented in the
> help message.
> I assume this one is the case.
> 
> If users want to install UAPI headers, 'headers_install' is
> the user-visible interface and it is already documented.
> 
> 

hpa and Boris prefer to add it, which I also agree.  But ofc it's your
call :)

If you don't want to add help for "headers", it probably still makes
sense to explicitly state that the headers are uapi headers, no?

Thanks!
     Xin

> 
> 
> 
>> Suggested-by: Borislav Petkov <bp@...en8.de>
>> Signed-off-by: Xin Li (Intel) <xin@...or.com>
>> ---
>>   Makefile | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 70bdbf2218fc..8f5aa710105e 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1659,7 +1659,8 @@ help:
>>          @echo  '  kernelrelease   - Output the release version string (use with make -s)'
>>          @echo  '  kernelversion   - Output the version stored in Makefile (use with make -s)'
>>          @echo  '  image_name      - Output the image name (use with make -s)'
>> -       @echo  '  headers_install - Install sanitised kernel headers to INSTALL_HDR_PATH'; \
>> +       @echo  '  headers         - Install sanitised kernel uapi headers to usr/include'
>> +       @echo  '  headers_install - Install sanitised kernel uapi headers to INSTALL_HDR_PATH'; \
>>           echo  '                    (default: $(INSTALL_HDR_PATH))'; \
>>           echo  ''
>>          @echo  'Static analysers:'
>>
>> base-commit: 7eb172143d5508b4da468ed59ee857c6e5e01da6
>> --
>> 2.48.1
>>
> 
> 
> --
> Best Regards
> Masahiro Yamada
> 
>