linux-kernel - Re: [PATCH v2] dt-bindings: rng: rockchip,rk3588-rng: Drop unnecessary status from example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqJShHSMzMwiYA79OppJYKKR8qN=1soXPV_hCZiXGyVkSg@mail.gmail.com>
Date: Mon, 10 Mar 2025 14:30:45 -0500
From: Rob Herring <robh@...nel.org>
To: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
Cc: Daniel Golle <daniel@...rotopia.org>, Aurelien Jarno <aurelien@...el32.net>, 
	Olivia Mackall <olivia@...enic.com>, Herbert Xu <herbert@...dor.apana.org.au>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Heiko Stuebner <heiko@...ech.de>, linux-crypto@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v2] dt-bindings: rng: rockchip,rk3588-rng: Drop
 unnecessary status from example

On Mon, Mar 10, 2025 at 7:49 AM Rob Herring <robh@...nel.org> wrote:
>
> On Fri, Mar 07, 2025 at 03:05:50PM +0100, Nicolas Frattaroli wrote:
> > On Friday, 7 March 2025 10:33:09 Central European Standard Time Krzysztof
> > Kozlowski wrote:
> > > Device nodes are enabled by default, so no need for 'status = "okay"' in
> > > the DTS example.
> > >
> > > Reviewed-by: Heiko Stuebner <heiko@...ech.de>
> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > >
> > > ---
> > >
> > > Changes in v2:
> > > 1. Drop unnecessary full stop in subject prefix after ':'.
> > > 2. Add Rb tag.
> > > ---
> > >  Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml
> > > b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml index
> > > 757967212f55..ca71b400bcae 100644
> > > --- a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml
> > > +++ b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml
> > > @@ -53,7 +53,6 @@ examples:
> > >          interrupts = <GIC_SPI 400 IRQ_TYPE_LEVEL_HIGH 0>;
> > >          clocks = <&scmi_clk SCMI_HCLK_SECURE_NS>;
> > >          resets = <&scmi_reset SCMI_SRST_H_TRNG_NS>;
> > > -        status = "okay";
> > >        };
> > >      };
> >
> > Hi,
> >
> > is there the possibility we could make dtschema as invoked by `make
> > dt_binding_check W=1` (or W=2) add a warning for examples that have disabled
> > or explicitly listed status properties when not needed? Or is this something
> > better handled in, say, checkpatch.pl?
> >
> > The question arises because dumb mistakes by me like this should ideally be
> > caught before they waste precious maintainer time.
> >
> > If it's best handled in dtschema, I can look into working on that so you guys
> > don't have to do even more work due to me.
>
> Trust me, I'm always looking for things to check automatically. :)
>
> I have something like that which adds a schema for examples only. I
> think there were some corner cases. I'll take a fresh look at it.

I got my check working again. i2c/i2c-demux-pinctrl.yaml is the
problematic one. Not sure what to do there.

Rob