linux-kernel - Re: [PATCH v3 4/9] dt-bindings: clock: brcm,kona-ccu: Add BCM281xx bus clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <145c65bf-fbb1-4256-aa36-2079fe42e1a3@gmail.com>
Date: Mon, 10 Mar 2025 21:13:08 +0100
From: Artur Weber <aweber.kernel@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>, Ray Jui
 <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Alex Elder <elder@...nel.org>,
 Stanislav Jakubek <stano.jakubek@...il.com>, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v3 4/9] dt-bindings: clock: brcm,kona-ccu: Add BCM281xx
 bus clocks

On 10.03.2025 10:43, Krzysztof Kozlowski wrote:
> On Sat, Mar 08, 2025 at 08:50:42AM +0100, Artur Weber wrote:
>> Add bus clocks corresponding to peripheral clocks currently supported
>> by the BCM281xx clock driver and add the relevant clock IDs to the
>> clock/bcm281xx.h dt-bindings header.
> 
> Please squash the patch so we see complete change.

> 
>>
>> Signed-off-by: Artur Weber <aweber.kernel@...il.com>
>> ---
>> Changes in v3:
>> - Add more clock output names to example
>> - Drop CLOCK_COUNT defines from the DT binding header
>>
>> Changes in v2:
>> - Add this commit (BCM281xx bus clocks)
>> ---
>>   .../devicetree/bindings/clock/brcm,kona-ccu.yaml   | 33 ++++++++++++++++++++--
>>   include/dt-bindings/clock/bcm281xx.h               | 19 +++++++++++++
>>   2 files changed, 50 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/brcm,kona-ccu.yaml b/Documentation/devicetree/bindings/clock/brcm,kona-ccu.yaml
>> index dff04e24e92829b890bf7cd336f0e083bdb30fa6..d00dcf916b45904177614c6f19a5df02abdf42f7 100644
>> --- a/Documentation/devicetree/bindings/clock/brcm,kona-ccu.yaml
>> +++ b/Documentation/devicetree/bindings/clock/brcm,kona-ccu.yaml
>> @@ -40,7 +40,7 @@ properties:
>>   
>>     clock-output-names:
>>       minItems: 1
>> -    maxItems: 14
>> +    maxItems: 20
>>   
>>   required:
>>     - compatible
>> @@ -61,6 +61,8 @@ allOf:
>>               - const: hub_timer
>>               - const: pmu_bsc
>>               - const: pmu_bsc_var
>> +            - const: hub_timer_apb
>> +            - const: pmu_bsc_apb
>>     - if:
>>         properties:
>>           compatible:
>> @@ -86,6 +88,13 @@ allOf:
>>               - const: usb_ic
>>               - const: hsic2_48m
>>               - const: hsic2_12m
>> +            - const: sdio1_ahb
>> +            - const: sdio2_ahb
>> +            - const: sdio3_ahb
>> +            - const: sdio4_ahb
>> +            - const: usb_ic_ahb
>> +            - const: hsic2_ahb
>> +            - const: usb_otg_ahb
>>     - if:
>>         properties:
>>           compatible:
>> @@ -116,6 +125,16 @@ allOf:
>>               - const: bsc2
>>               - const: bsc3
>>               - const: pwm
>> +            - const: uartb_apb
>> +            - const: uartb2_apb
>> +            - const: uartb3_apb
>> +            - const: uartb4_apb
>> +            - const: ssp0_apb
>> +            - const: ssp2_apb
>> +            - const: bsc1_apb
>> +            - const: bsc2_apb
>> +            - const: bsc3_apb
>> +            - const: pwm_apb
> 
> Why pwm_apb cannot be after pwm? Any idea for sorting here?

I placed all bus clocks corresponding to peripheral clocks at the end of
the clock list (so as to not modify the IDs of previous clocks), in the
same order as their corresponding peripheral clocks. This applies both
to the dt-bindings/clock/bcm281xx.h header and to the clock binding
here (I kept the same order of clock names here as clock IDs in the
header).

The same reasoning applies to the BCM21664 bus clocks patch.

Best regards
Artur