linux-kernel - Re: [patch V3 09/18] posix-timers: Rework timer removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875xkh2y5e.ffs@tglx>
Date: Mon, 10 Mar 2025 07:33:01 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Frederic Weisbecker <frederic@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Anna-Maria Behnsen
 <anna-maria@...utronix.de>, Benjamin Segall <bsegall@...gle.com>, Eric
 Dumazet <edumazet@...gle.com>, Andrey Vagin <avagin@...nvz.org>, Pavel
 Tikhomirov <ptikhomirov@...tuozzo.com>, Peter Zijlstra
 <peterz@...radead.org>, Cyrill Gorcunov <gorcunov@...il.com>
Subject: Re: [patch V3 09/18] posix-timers: Rework timer removal

On Mon, Mar 10 2025 at 00:17, Frederic Weisbecker wrote:
> Le Sat, Mar 08, 2025 at 05:48:32PM +0100, Thomas Gleixner a écrit :
>> @@ -988,90 +988,56 @@ static inline void posix_timer_cleanup_i
>>  	}
>>  }
>>  
>> -/* Delete a POSIX.1b interval timer. */
>> -SYSCALL_DEFINE1(timer_delete, timer_t, timer_id)
>> +static void posix_timer_delete(struct k_itimer *timer)
>>  {
>> -	struct k_itimer *timer = lock_timer(timer_id);
>> -
>> -retry_delete:
>> -	if (!timer)
>> -		return -EINVAL;
>> -
>> -	/* Prevent signal delivery and rearming. */
>> +	/*
>> +	 * Invalidate the timer, remove it from the linked list and remove
>> +	 * it from the ignored list if pending.
>> +	 *
>> +	 * The invalidation must be written with siglock held so that the
>> +	 * signal code observes timer->it_valid == false in do_sigaction(),
>
> I guess it_valid is a leftover from previous attempts?

Ooops, yes. Fixed now.

> Aside that and the lost WARN_ON in signal delivery:
>
> Reviewed-by: Frederic Weisbecker <frederic@...nel.org>