linux-kernel - Re: [PATCH] hyperv: Remove unused union and structs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ACB6A959-C2CD-44E7-A1D6-AB9263C29D4D@linux.dev>
Date: Mon, 10 Mar 2025 21:40:59 +0100
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Michael Kelley <mhklinux@...look.com>
Cc: "K. Y. Srinivasan" <kys@...rosoft.com>,
 Haiyang Zhang <haiyangz@...rosoft.com>,
 Wei Liu <wei.liu@...nel.org>,
 Dexuan Cui <decui@...rosoft.com>,
 "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hyperv: Remove unused union and structs

On 10. Mar 2025, at 21:21, Michael Kelley wrote:
> 
> It appears to me that struct vmdata_gpa_direct and struct
> vmadditional_data are also unused. Did you keep them for
> some reason? Or could they also be deleted in this patch?

I kept vmdata_gpa_direct because it is referenced in multiple comments
of other structs, for example:

/* The format must be the same as struct vmdata_gpa_direct */
struct vmbus_channel_packet_page_buffer {
	...
}

I only checked the structs used in the union and didn't check
vmadditional_data or any others, but I'll submit a v2 and remove it.

Thanks,
Thorsten