linux-kernel - Re: [PATCH v2 08/11] perf python: Avoid duplicated code in get_tracepoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z89RsRu3SMrSsAx5@x1>
Date: Mon, 10 Mar 2025 17:55:13 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Yicong Yang <yangyicong@...ilicon.com>,
	James Clark <james.clark@...aro.org>,
	"Dr. David Alan Gilbert" <linux@...blig.org>,
	Levi Yun <yeoreum.yun@....com>, Ze Gao <zegao2021@...il.com>,
	Weilin Wang <weilin.wang@...el.com>, Xu Yang <xu.yang_2@....com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	Howard Chu <howardchu95@...il.com>
Subject: Re: [PATCH v2 08/11] perf python: Avoid duplicated code in
 get_tracepoint_field

On Fri, Feb 28, 2025 at 02:23:05PM -0800, Ian Rogers wrote:
> The code replicates computations done in evsel__tp_format, reuse
> evsel__tp_format to simplify the python C code.

Reviewed-by: Arnaldo Carvalho de Melo <acme@...hat.com>

- Arnaldo
 
> Reviewed-by: Howard Chu <howardchu95@...il.com>
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/util/python.c | 17 ++++-------------
>  1 file changed, 4 insertions(+), 13 deletions(-)
> 
> diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c
> index e244cc74f16d..7f2513ffe866 100644
> --- a/tools/perf/util/python.c
> +++ b/tools/perf/util/python.c
> @@ -342,23 +342,14 @@ get_tracepoint_field(struct pyrf_event *pevent, PyObject *attr_name)
>  {
>  	const char *str = _PyUnicode_AsString(PyObject_Str(attr_name));
>  	struct evsel *evsel = pevent->evsel;
> +	struct tep_event *tp_format = evsel__tp_format(evsel);
>  	struct tep_format_field *field;
>  
> -	if (!evsel->tp_format) {
> -		struct tep_event *tp_format;
> -
> -		tp_format = trace_event__tp_format_id(evsel->core.attr.config);
> -		if (IS_ERR_OR_NULL(tp_format))
> -			return NULL;
> -
> -		evsel->tp_format = tp_format;
> -	}
> -
> -	field = tep_find_any_field(evsel->tp_format, str);
> -	if (!field)
> +	if (IS_ERR_OR_NULL(tp_format))
>  		return NULL;
>  
> -	return tracepoint_field(pevent, field);
> +	field = tep_find_any_field(tp_format, str);
> +	return field ? tracepoint_field(pevent, field) : NULL;
>  }
>  #endif /* HAVE_LIBTRACEEVENT */
>  
> -- 
> 2.48.1.711.g2feabab25a-goog