linux-kernel - Re: [PATCH] compiler_types: Introduce __nonstring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202503101448.1A6978F79E@keescook>
Date: Mon, 10 Mar 2025 14:48:51 -0700
From: Kees Cook <kees@...nel.org>
To: Miguel Ojeda <ojeda@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>, "Rafael J. Wysocki" <rafael@...nel.org>,
	Len Brown <lenb@...nel.org>, Marco Elver <elver@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Hao Luo <haoluo@...gle.com>, Masahiro Yamada <masahiroy@...nel.org>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Johannes Weiner <hannes@...xchg.org>, linux-acpi@...r.kernel.org,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Alexander Potapenko <glider@...gle.com>,
	Yafang Shao <laoar.shao@...il.com>,
	Jan Hendrik Farr <kernel@...rr.cc>,
	Tony Ambardar <tony.ambardar@...il.com>,
	Alexander Lobakin <aleksander.lobakin@...el.com>,
	Alice Ryhl <aliceryhl@...gle.com>, Tejun Heo <tj@...nel.org>,
	Yoann Congal <yoann.congal@...le.fr>,
	Roman Gushchin <roman.gushchin@...ux.dev>,
	Jens Axboe <axboe@...nel.dk>, Chen Ridong <chenridong@...wei.com>,
	Mark Rutland <mark.rutland@....com>, Jann Horn <jannh@...gle.com>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] compiler_types: Introduce __nonstring_array

On Mon, Mar 10, 2025 at 02:42:48PM -0700, Kees Cook wrote:
> In file included from ../include/acpi/actbl.h:371,                                                                   from ../include/acpi/acpi.h:26,                                                                     from ../include/linux/acpi.h:26,
>                  from ../drivers/acpi/tables.c:19:

Ugh, this whole paste went poorly. I've fixed it locally. It should be:

In file included from ../include/acpi/actbl.h:371,
                 from ../include/acpi/acpi.h:26,
                 from ../include/linux/acpi.h:26,
                 from ../drivers/acpi/tables.c:19:
../include/acpi/actbl1.h:30:33: warning: initializer-string for array of 'char' truncates NUL terminator but destination lacks 'nonstring' attribute (5 chars into 4 available) [-Wunterminated-string-initialization]
   30 | #define ACPI_SIG_BERT           "BERT"  /* Boot Error Record Table */
      |                                 ^~~~~~
../drivers/acpi/tables.c:400:9: note: in expansion of macro 'ACPI_SIG_BERT'
  400 |         ACPI_SIG_BERT, ACPI_SIG_BGRT, ACPI_SIG_CPEP, ACPI_SIG_ECDT,
      |         ^~~~~~~~~~~~~
../include/acpi/actbl1.h:31:33: warning: initializer-string for array of 'char' truncates NUL terminator but destination lacks 'nonstring' attribute (5 chars into 4 available) [-Wunterminated-string-initialization]
   31 | #define ACPI_SIG_BGRT           "BGRT"  /* Boot Graphics Resource Table */
      |                                 ^~~~~~

-- 
Kees Cook