linux-kernel - Re: [PATCH 1/2] dt-bindings: leds: add Texas Instruments TPS6131x flash LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed09c9c5-f4d9-4b09-a272-f3946e971230@kernel.org>
Date: Mon, 10 Mar 2025 08:43:06 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Matthias Fend <matthias.fend@...end.at>, Conor Dooley <conor@...nel.org>
Cc: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-leds@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 bsp-development.geo@...ca-geosystems.com
Subject: Re: [PATCH 1/2] dt-bindings: leds: add Texas Instruments TPS6131x
 flash LED driver

On 10/03/2025 08:20, Matthias Fend wrote:
> Hi Conor,
> 
> Am 28.02.2025 um 19:24 schrieb Conor Dooley:
>> On Fri, Feb 28, 2025 at 11:31:23AM +0100, Matthias Fend wrote:
>>> Document Texas Instruments TPS61310/TPS61311 flash LED driver devicetree
>>> bindings.
>>>
>>> Signed-off-by: Matthias Fend <matthias.fend@...end.at>
>>> ---
>>>   .../devicetree/bindings/leds/ti,tps6131x.yaml      | 123 +++++++++++++++++++++
>>>   1 file changed, 123 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/leds/ti,tps6131x.yaml b/Documentation/devicetree/bindings/leds/ti,tps6131x.yaml
>>> new file mode 100644
>>> index 0000000000000000000000000000000000000000..c08b3cef7abcec07237d3271456ff1f888b2b809
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/leds/ti,tps6131x.yaml
>>
>> With a filename matching one of the compatibles in the file,
>> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> 
> thank you very much for your feedback.
> Since I found different variants in the LED bindings, I wasn't quite 
> sure here.
> So is it okay if I simply rename the file to 'ti,tps61310.yaml', even 
> though there are multiple compatible strings and the driver is called 
> leds-tps6131x?
> 
I think that was exactly the review comment you got.

Best regards,
Krzysztof