linux-kernel - Re: [PATCH] mfd: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13715971.uLZWGnKmhe@diego>
Date: Mon, 10 Mar 2025 09:37:43 +0100
From: Heiko Stübner <heiko@...ech.de>
To: lee@...nel.org, Chen Ni <nichen@...as.ac.cn>
Cc: linux-kernel@...r.kernel.org, Chen Ni <nichen@...as.ac.cn>
Subject: Re: [PATCH] mfd: Convert comma to semicolon

Am Montag, 10. März 2025, 04:11:45 MEZ schrieb Chen Ni:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.

oh ... wonder how I could've messed that up.

And thanks a lot for finding this.

> Found by inspection.
> No functional change intended.
> Compile tested only.
> 

Fixes: 998f70d1806b ("mfd: Add base driver for qnap-mcu devices")

Reviewed-by: Heiko Stuebner <heiko@...ech.de>

> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  drivers/mfd/qnap-mcu.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/qnap-mcu.c b/drivers/mfd/qnap-mcu.c
> index 4be39d8b2905..89a8a1913d42 100644
> --- a/drivers/mfd/qnap-mcu.c
> +++ b/drivers/mfd/qnap-mcu.c
> @@ -158,9 +158,9 @@ int qnap_mcu_exec(struct qnap_mcu *mcu,
>  
>  	mutex_lock(&mcu->bus_lock);
>  
> -	reply->data = rx,
> -	reply->length = length,
> -	reply->received = 0,
> +	reply->data = rx;
> +	reply->length = length;
> +	reply->received = 0;
>  	reinit_completion(&reply->done);
>  
>  	qnap_mcu_write(mcu, cmd_data, cmd_data_size);
>