linux-kernel - Re: [PATCH RFC net-next v1] page_pool: import Jesper's page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a59txn3v.fsf@toke.dk>
Date: Mon, 10 Mar 2025 10:15:48 +0100
From: Toke Høiland-Jørgensen <toke@...e.dk>
To: Mina Almasry <almasrymina@...gle.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Jesper Dangaard Brouer <hawk@...nel.org>, Andrew Morton
 <akpm@...ux-foundation.org>, Ilias Apalodimas
 <ilias.apalodimas@...aro.org>, Jakub Kicinski <kuba@...nel.org>, Mina
 Almasry <almasrymina@...gle.com>
Subject: Re: [PATCH RFC net-next v1] page_pool: import Jesper's page_pool
 benchmark

Mina Almasry <almasrymina@...gle.com> writes:

> From: Jesper Dangaard Brouer <hawk@...nel.org>
>
> We frequently consult with Jesper's out-of-tree page_pool benchmark to
> evaluate page_pool changes.
>
> Consider importing the benchmark into the upstream linux kernel tree so
> that (a) we're all running the same version, (b) pave the way for shared
> improvements, and (c) maybe one day integrate it with nipa, if possible.
>
> I imported the bench_page_pool_simple from commit 35b1716d0c30 ("Add
> page_bench06_walk_all"), from this repository:
> https://github.com/netoptimizer/prototype-kernel.git
>
> I imported the benchmark, largely as-is. I only fixed build or
> checkpatch issues.
>
> Cc: Jesper Dangaard Brouer <hawk@...nel.org>
> Cc: Ilias Apalodimas <ilias.apalodimas@...aro.org>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Toke Høiland-Jørgensen <toke@...e.dk>
> Cc: netdev@...r.kernel.org
> Signed-off-by: Mina Almasry <almasrymina@...gle.com>
>
> ---
>
> RFC discussion points:
> - Desirable to import it?

I think so, yeah.

> - Can the benchmark be imported as-is for an initial version? Or needs
>   lots of modifications?

One thing that I was discussing with Jesper the other day is that the
current version allocates the page_pool itself in softirq context, which
leads to some "may sleep" warning. I think we should fix that before
upstreaming.

> - Code location. I retained the location in Jesper's tree, but a path
>   like net/core/bench/ may make more sense.

No strong opinion on this...

-Toke