linux-kernel - Re: [PATCH hyperv-next v5 07/11] dt-bindings: microsoft,vmbus: Add interrupts and DMA coherence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250310-demonic-ferret-of-judgment-5dbdbf@krzk-bin>
Date: Mon, 10 Mar 2025 10:28:44 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Roman Kisel <romank@...ux.microsoft.com>
Cc: arnd@...db.de, bhelgaas@...gle.com, bp@...en8.de, 
	catalin.marinas@....com, conor+dt@...nel.org, dave.hansen@...ux.intel.com, 
	decui@...rosoft.com, haiyangz@...rosoft.com, hpa@...or.com, joey.gouly@....com, 
	krzk+dt@...nel.org, kw@...ux.com, kys@...rosoft.com, lenb@...nel.org, 
	lpieralisi@...nel.org, manivannan.sadhasivam@...aro.org, mark.rutland@....com, 
	maz@...nel.org, mingo@...hat.com, oliver.upton@...ux.dev, rafael@...nel.org, 
	robh@...nel.org, ssengar@...ux.microsoft.com, sudeep.holla@....com, 
	suzuki.poulose@....com, tglx@...utronix.de, wei.liu@...nel.org, will@...nel.org, 
	yuzenghui@...wei.com, devicetree@...r.kernel.org, kvmarm@...ts.linux.dev, 
	linux-acpi@...r.kernel.org, linux-arch@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org, 
	x86@...nel.org, apais@...rosoft.com, benhill@...rosoft.com, 
	bperkins@...rosoft.com, sunilmut@...rosoft.com
Subject: Re: [PATCH hyperv-next v5 07/11] dt-bindings: microsoft,vmbus: Add
 interrupts and DMA coherence

On Fri, Mar 07, 2025 at 02:02:59PM -0800, Roman Kisel wrote:
> To boot on ARM64, VMBus requires configuring interrupts. Missing
> DMA coherence property is sub-optimal as the VMBus transations are
> cache-coherent.
> 
> Add interrupts to be able to boot on ARM64. Add DMA coherence to
> avoid doing extra work on maintaining caches on ARM64.

How do you add it?

> 
> Signed-off-by: Roman Kisel <romank@...ux.microsoft.com>
> ---
>  .../devicetree/bindings/bus/microsoft,vmbus.yaml          | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/bus/microsoft,vmbus.yaml b/Documentation/devicetree/bindings/bus/microsoft,vmbus.yaml
> index a8d40c766dcd..3ab7d0116626 100644
> --- a/Documentation/devicetree/bindings/bus/microsoft,vmbus.yaml
> +++ b/Documentation/devicetree/bindings/bus/microsoft,vmbus.yaml
> @@ -28,13 +28,16 @@ properties:
>  required:
>    - compatible
>    - ranges
> +  - interrupts
>    - '#address-cells'
>    - '#size-cells'
>  
> -additionalProperties: false
> +additionalProperties: true

This is neither explained in commit msg nor correct.

Drop the change. You cannot have device bindings ending with 'true'
here - see talks, example-bindings, writing-schema and whatever resource
is there.

Best regards,
Krzysztof