linux-kernel - Re: [PATCH net-next v2 1/7] net: usb: lan78xx: Convert to PHYlink for improved PHY and MAC management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8676rcaq6h4X8To@pengutronix.de>
Date: Mon, 10 Mar 2025 11:16:10 +0100
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Thangaraj.S@...rochip.com, andrew+netdev@...n.ch, davem@...emloft.net,
	Rengarajan.S@...rochip.com, Woojung.Huh@...rochip.com,
	pabeni@...hat.com, edumazet@...gle.com, kuba@...nel.org,
	phil@...pberrypi.org, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next v2 1/7] net: usb: lan78xx: Convert to PHYlink
 for improved PHY and MAC management

On Mon, Mar 10, 2025 at 10:11:29AM +0000, Russell King (Oracle) wrote:
> On Mon, Mar 10, 2025 at 10:58:38AM +0100, Oleksij Rempel wrote:
> > Hi Thangaraj,
> > 
> > On Mon, Mar 10, 2025 at 09:29:45AM +0000, Thangaraj.S@...rochip.com wrote:
> > > > -       mii_adv_to_linkmode_adv_t(fc, mii_adv);
> > > > -       linkmode_or(phydev->advertising, fc, phydev->advertising);
> > > > +       phy_suspend(phydev);
> > > > 
> > > 
> > > Why phy_suspend called in the init? Is there any specific reason?
> > 
> > In my tests with EVB-LAN7801-EDS, the attached PHY stayed UP in initial
> > state.
> 
> Why is that an issue?

The local interface was in the administrative DOWN state, but link was up:
- port LEDs are on
- link partner sees the link is UP.

It is not a big deal, but for me it looks inconsistent.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |