linux-kernel - Re: [PATCH v1 1/1] hwmon: (dell-smm) Increment the number of fans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9865e1b9-6f03-4f54-83fc-73591646b74c@roeck-us.net>
Date: Sun, 9 Mar 2025 17:11:03 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Kurt Borja <kuurtb@...il.com>, linux-hwmon@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Jean Delvare <jdelvare@...e.com>, Jonathan Corbet <corbet@....net>,
 Pali Rohár <pali@...nel.org>
Subject: Re: [PATCH v1 1/1] hwmon: (dell-smm) Increment the number of fans

On 3/3/25 21:52, Kurt Borja wrote:
> Some Alienware laptops that support the SMM interface, may have up to 4
> fans.
> 
> Tested on an Alienware x15 r1.
> 
> Signed-off-by: Kurt Borja <kuurtb@...il.com>
> ---
> Hi all,
> 
> Guenter, if you prefer a different patch for the documentation, let me
> know.
> 

It looks ok, I'd just like to get a confirmation from someone with a
system with fewer fans that this doesn't cause trouble on those.

Thanks,
Guenter

> ~ Kurt
> 
>   Documentation/hwmon/dell-smm-hwmon.rst | 14 +++++++-------
>   drivers/hwmon/dell-smm-hwmon.c         |  5 ++++-
>   2 files changed, 11 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/hwmon/dell-smm-hwmon.rst b/Documentation/hwmon/dell-smm-hwmon.rst
> index 74905675d71f..5a4edb6565cf 100644
> --- a/Documentation/hwmon/dell-smm-hwmon.rst
> +++ b/Documentation/hwmon/dell-smm-hwmon.rst
> @@ -32,12 +32,12 @@ Temperature sensors and fans can be queried and set via the standard
>   =============================== ======= =======================================
>   Name				Perm	Description
>   =============================== ======= =======================================
> -fan[1-3]_input                  RO      Fan speed in RPM.
> -fan[1-3]_label                  RO      Fan label.
> -fan[1-3]_min                    RO      Minimal Fan speed in RPM
> -fan[1-3]_max                    RO      Maximal Fan speed in RPM
> -fan[1-3]_target                 RO      Expected Fan speed in RPM
> -pwm[1-3]                        RW      Control the fan PWM duty-cycle.
> +fan[1-4]_input                  RO      Fan speed in RPM.
> +fan[1-4]_label                  RO      Fan label.
> +fan[1-4]_min                    RO      Minimal Fan speed in RPM
> +fan[1-4]_max                    RO      Maximal Fan speed in RPM
> +fan[1-4]_target                 RO      Expected Fan speed in RPM
> +pwm[1-4]                        RW      Control the fan PWM duty-cycle.
>   pwm1_enable                     WO      Enable or disable automatic BIOS fan
>                                           control (not supported on all laptops,
>                                           see below for details).
> @@ -93,7 +93,7 @@ Again, when you find new codes, we'd be happy to have your patches!
>   ---------------------------
>   
>   The driver also exports the fans as thermal cooling devices with
> -``type`` set to ``dell-smm-fan[1-3]``. This allows for easy fan control
> +``type`` set to ``dell-smm-fan[1-4]``. This allows for easy fan control
>   using one of the thermal governors.
>   
>   Module parameters
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index cd00adaad1b4..79e5606e6d2f 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -73,7 +73,7 @@
>   #define DELL_SMM_LEGACY_EXECUTE	0x1
>   
>   #define DELL_SMM_NO_TEMP	10
> -#define DELL_SMM_NO_FANS	3
> +#define DELL_SMM_NO_FANS	4
>   
>   struct smm_regs {
>   	unsigned int eax;
> @@ -1074,11 +1074,14 @@ static const struct hwmon_channel_info * const dell_smm_info[] = {
>   			   HWMON_F_INPUT | HWMON_F_LABEL | HWMON_F_MIN | HWMON_F_MAX |
>   			   HWMON_F_TARGET,
>   			   HWMON_F_INPUT | HWMON_F_LABEL | HWMON_F_MIN | HWMON_F_MAX |
> +			   HWMON_F_TARGET,
> +			   HWMON_F_INPUT | HWMON_F_LABEL | HWMON_F_MIN | HWMON_F_MAX |
>   			   HWMON_F_TARGET
>   			   ),
>   	HWMON_CHANNEL_INFO(pwm,
>   			   HWMON_PWM_INPUT | HWMON_PWM_ENABLE,
>   			   HWMON_PWM_INPUT,
> +			   HWMON_PWM_INPUT,
>   			   HWMON_PWM_INPUT
>   			   ),
>   	NULL