linux-kernel - Re: [PATCH RESEND 0/4] media: i2c: imx214: Add support for 23.88MHz clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z87I2xh0HY-YD_tZ@kekkonen.localdomain>
Date: Mon, 10 Mar 2025 11:11:23 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: git@...tzsch.eu
Cc: Ricardo Ribalda <ribalda@...nel.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 0/4] media: i2c: imx214: Add support for 23.88MHz
 clock

Hi André,

On Sat, Mar 08, 2025 at 10:47:54PM +0100, André Apitzsch via B4 Relay wrote:
> The imx214 driver currently supports only a 24MHz external clock. But
> there are devices, like Qualcomm-MSM8916-based phones, which cannot
> provide this frequency. To make the sensor usable by those devices, add
> support for 23.88MHz clock.
> 
> Signed-off-by: André Apitzsch <git@...tzsch.eu>
> ---
> André Apitzsch (4):
>       media: i2c: imx214: Calculate link bit rate from clock frequency
>       media: i2c: imx214: Prepare for variable clock frequency
>       media: i2c: imx214: Read clock frequency from device tree
>       media: i2c: imx214: Add support for 23.88MHz clock
> 
>  drivers/media/i2c/imx214.c | 188 +++++++++++++++++++++++++++++++++++----------
>  1 file changed, 146 insertions(+), 42 deletions(-)

Thanks for the patches.

Do you think the driver could use the CCS PLL calculator? The PLL appears
to be compliant. The AR0234 driver will do the same. (The sensor might just
work with the CCS driver, too, but that's another discussion.)

-- 
Kind regards,

Sakari Ailus