linux-kernel - Re: [PATCH 2/2] leds: tps6131x: add support for Texas Instruments TPS6131X flash LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac971cdc-24dc-4d9d-aa04-7b3324b7413c@kernel.org>
Date: Mon, 10 Mar 2025 12:46:28 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Matthias Fend <matthias.fend@...end.at>, Pavel Machek <pavel@....cz>,
 Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, bsp-development.geo@...ca-geosystems.com
Subject: Re: [PATCH 2/2] leds: tps6131x: add support for Texas Instruments
 TPS6131X flash LED driver

On 10/03/2025 09:04, Matthias Fend wrote:
>>> +
>>> +static void tps6131x_remove(struct i2c_client *client)
>>> +{
>>> +	struct tps6131x *tps6131x = i2c_get_clientdata(client);
>>> +
>>> +	v4l2_flash_release(tps6131x->v4l2_flash);
>>> +
>>> +	cancel_delayed_work_sync(&tps6131x->torch_refresh_work);
>>> +}
>>> +
>>> +static const struct of_device_id of_tps6131x_leds_match[] = {
>>> +	{ .compatible = "ti,tps61310" },
>>> +	{ .compatible = "ti,tps61311" },
>>
>>
>> No differences? So devices are fully compatible? Then it should be
>> expressed in the binding with fallback. Or the binding description or
>> commit msg should explain why they are not compatible.
> 
> Yes, from a software perspective both are identical.
> The only difference I found between the two variants are different 
> valley current limits. These are described in the bindings.

So use compatibility and fallbacks (see example-schema or hundreds of
other bindings).

Best regards,
Krzysztof