linux-kernel - Re: [EXTERNAL] Re: [PATCH net] net: mana: Support holes in device list reply msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250310121134.GA12177@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Date: Mon, 10 Mar 2025 05:11:34 -0700
From: Shradha Gupta <shradhagupta@...ux.microsoft.com>
To: Haiyang Zhang <haiyangz@...rosoft.com>
Cc: Jakub Kicinski <kuba@...nel.org>,
	"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Dexuan Cui <decui@...rosoft.com>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	KY Srinivasan <kys@...rosoft.com>,
	Paul Rosswurm <paulros@...rosoft.com>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"vkuznets@...hat.com" <vkuznets@...hat.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"wei.liu@...nel.org" <wei.liu@...nel.org>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"leon@...nel.org" <leon@...nel.org>, Long Li <longli@...rosoft.com>,
	"ssengar@...ux.microsoft.com" <ssengar@...ux.microsoft.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"daniel@...earbox.net" <daniel@...earbox.net>,
	"john.fastabend@...il.com" <john.fastabend@...il.com>,
	"bpf@...r.kernel.org" <bpf@...r.kernel.org>,
	"ast@...nel.org" <ast@...nel.org>,
	"hawk@...nel.org" <hawk@...nel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH net] net: mana: Support holes in device
 list reply msg

On Sun, Mar 09, 2025 at 10:01:33PM +0000, Haiyang Zhang wrote:
> 
> 
> > -----Original Message-----
> > From: Jakub Kicinski <kuba@...nel.org>
> > Sent: Friday, March 7, 2025 10:50 PM
> > To: Haiyang Zhang <haiyangz@...rosoft.com>
> > Cc: linux-hyperv@...r.kernel.org; netdev@...r.kernel.org; Dexuan Cui
> > <decui@...rosoft.com>; stephen@...workplumber.org; KY Srinivasan
> > <kys@...rosoft.com>; Paul Rosswurm <paulros@...rosoft.com>;
> > olaf@...fle.de; vkuznets@...hat.com; davem@...emloft.net;
> > wei.liu@...nel.org; edumazet@...gle.com; pabeni@...hat.com;
> > leon@...nel.org; Long Li <longli@...rosoft.com>;
> > ssengar@...ux.microsoft.com; linux-rdma@...r.kernel.org;
> > daniel@...earbox.net; john.fastabend@...il.com; bpf@...r.kernel.org;
> > ast@...nel.org; hawk@...nel.org; tglx@...utronix.de;
> > shradhagupta@...ux.microsoft.com; linux-kernel@...r.kernel.org;
> > stable@...r.kernel.org
> > Subject: [EXTERNAL] Re: [PATCH net] net: mana: Support holes in device
> > list reply msg
> > 
> > On Wed,  5 Mar 2025 13:46:21 -0800 Haiyang Zhang wrote:
> > > -	for (i = 0; i < max_num_devs; i++) {
> > > +	for (i = 0; i < GDMA_DEV_LIST_SIZE &&
> > > +		found_dev < resp.num_of_devs; i++) {
> > 
> > unfortunate mis-indent here, it blend with the code.
> > checkpatch is right that it should be aligned with opening bracket
> Will fix it.
> 
> > 
> > >  		dev = resp.devs[i];
> > >  		dev_type = dev.type;
> > >
> > > +		/* Skip empty devices */
> > > +		if (dev.as_uint32 == 0)
> > > +			continue;
> > > +
> > > +		found_dev++;
> > > +		dev_info(gc->dev, "Got devidx:%u, type:%u, instance:%u\n", i,
> > > +			 dev.type, dev.instance);
> > 
> > Are you sure you want to print this info message for each device,
> > each time it's probed? Seems pretty noisy. We generally recommend
> > printing about _unusual_ things.
> Ok. I can remove it.
How about a dev_dbg instead?
> 
> Thanks,
> - Haiyang