linux-kernel - Re: [RFC PATCH 09/24] dt-bindings: media: i2c: max96714: make i2c-gate conditional on compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250310123207.GA3853920-robh@kernel.org>
Date: Mon, 10 Mar 2025 07:32:07 -0500
From: Rob Herring <robh@...nel.org>
To: Cosmin Tanislav <demonsingur@...il.com>
Cc: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
	Niklas Söderlund <niklas.soderlund@...natech.se>,
	Cosmin Tanislav <cosmin.tanislav@...log.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Julien Massot <julien.massot@...labora.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Bjorn Andersson <quic_bjorande@...cinc.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Biju Das <biju.das.jz@...renesas.com>,
	Taniya Das <quic_tdas@...cinc.com>,
	Nícolas F . R . A . Prado <nfraprado@...labora.com>,
	Eric Biggers <ebiggers@...gle.com>,
	Javier Carrasco <javier.carrasco@...fvision.net>,
	Ross Burton <ross.burton@....com>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Hans Verkuil <hverkuil@...all.nl>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Umang Jain <umang.jain@...asonboard.com>,
	Zhi Mao <zhi.mao@...iatek.com>,
	Kieran Bingham <kieran.bingham@...asonboard.com>,
	Dongcheng Yan <dongcheng.yan@...el.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
	Tommaso Merciai <tomm.merciai@...il.com>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Ricardo Ribalda <ribalda@...omium.org>,
	Ihor Matushchak <ihor.matushchak@...box.net>,
	Laurentiu Palcu <laurentiu.palcu@....nxp.com>,
	linux-media@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-staging@...ts.linux.dev, linux-gpio@...r.kernel.org
Subject: Re: [RFC PATCH 09/24] dt-bindings: media: i2c: max96714: make
 i2c-gate conditional on compatible

On Sat, Mar 08, 2025 at 08:33:38PM +0200, Cosmin Tanislav wrote:
> Devices to be added in following patches don't use I2C gate.
> 
> Make this property conditional on the compatible strings.
> 
> Signed-off-by: Cosmin Tanislav <demonsingur@...il.com>
> ---
>  .../bindings/media/i2c/maxim,max96714.yaml    | 21 ++++++++++++-------
>  1 file changed, 13 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96714.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96714.yaml
> index 2f453189338f..d0a2aaf7df9c 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max96714.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96714.yaml
> @@ -84,14 +84,6 @@ properties:
>      required:
>        - port@1
>  
> -  i2c-gate:
> -    $ref: /schemas/i2c/i2c-gate.yaml
> -    unevaluatedProperties: false
> -    description:
> -      The MAX96714 will pass through and forward the I2C requests from the
> -      incoming I2C bus over the GMSL2 link. Therefore it supports an i2c-gate
> -      subnode to configure a serializer.
> -
>    port0-poc-supply:
>      description: Regulator providing Power over Coax for the GMSL port
>  
> @@ -101,6 +93,19 @@ required:
>    - ports
>  
>  additionalProperties: false
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - maxim,max96714
> +              - maxim,max96714f
> +    then:
> +      properties:
> +        i2c-gate:

Leave the original definition, invert the 'if', and here you just need:

i2c-gate: false

> +          $ref: /schemas/i2c/i2c-gate.yaml
> +          unevaluatedProperties: false
>  
>  examples:
>    - |
> -- 
> 2.48.1
>