linux-kernel - Re: [PATCH v3 00/14] KVM: arm64: FEAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86zfhtni4u.wl-maz@kernel.org>
Date: Mon, 10 Mar 2025 13:13:21 +0000
From: Marc Zyngier <maz@...nel.org>
To: Oliver Upton <oliver.upton@...ux.dev>
Cc: kvmarm@...ts.linux.dev,
	Joey Gouly <joey.gouly@....com>,
	Suzuki K Poulose <suzuki.poulose@....com>,
	Zenghui Yu <yuzenghui@...wei.com>,
	Mingwei Zhang <mizhang@...gle.com>,
	Colton Lewis <coltonlewis@...gle.com>,
	Raghavendra Rao Ananta <rananta@...gle.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Janne Grunau <j@...nau.net>
Subject: Re: [PATCH v3 00/14] KVM: arm64: FEAT_PMUv3 on Apple hardware

On Wed, 05 Mar 2025 20:26:27 +0000,
Oliver Upton <oliver.upton@...ux.dev> wrote:
> 
> Hopefully close to the last spin, this time addressing Marc's comments
> on v2.
> 
> Full details found in the v1 cover letter.
> 
> v1: https://lore.kernel.org/kvmarm/20241217212048.3709204-1-oliver.upton@linux.dev/
> v2: https://lore.kernel.org/kvmarm/20250203183111.191519-1-oliver.upton@linux.dev/
> 
> v2 -> v3:
>  - Reorder and restructure patches to include map_pmuv3_event()
>    definition w/ KVM usage.
>  - Disallow events that lack a valid PMUv3 -> HW mapping
>  - Various minor fixes/typos
> 
> Oliver Upton (14):
>   drivers/perf: apple_m1: Refactor event select/filter configuration
>   drivers/perf: apple_m1: Support host/guest event filtering
>   KVM: arm64: Compute PMCEID from arm_pmu's event bitmaps
>   KVM: arm64: Always support SW_INCR PMU event
>   KVM: arm64: Use a cpucap to determine if system supports FEAT_PMUv3
>   KVM: arm64: Drop kvm_arm_pmu_available static key
>   KVM: arm64: Use guard() to cleanup usage of arm_pmus_lock
>   KVM: arm64: Move PMUVer filtering into KVM code
>   KVM: arm64: Compute synthetic sysreg ESR for Apple PMUv3 traps
>   KVM: arm64: Advertise PMUv3 if IMPDEF traps are present
>   KVM: arm64: Remap PMUv3 events onto hardware
>   drivers/perf: apple_m1: Provide helper for mapping PMUv3 events
>   KVM: arm64: Provide 1 event counter on IMPDEF hardware
>   arm64: Enable IMP DEF PMUv3 traps on Apple M*
> 
>  arch/arm64/include/asm/apple_m1_pmu.h   |   1 +
>  arch/arm64/include/asm/cpucaps.h        |   2 +
>  arch/arm64/include/asm/cpufeature.h     |  28 +----
>  arch/arm64/kernel/cpu_errata.c          |  44 ++++++++
>  arch/arm64/kernel/cpufeature.c          |  28 +++++
>  arch/arm64/kernel/image-vars.h          |   5 -
>  arch/arm64/kvm/arm.c                    |   4 +-
>  arch/arm64/kvm/hyp/include/hyp/switch.h |   4 +-
>  arch/arm64/kvm/hyp/vhe/switch.c         |  22 ++++
>  arch/arm64/kvm/pmu-emul.c               | 138 +++++++++++++++++-------
>  arch/arm64/kvm/pmu.c                    |  10 +-
>  arch/arm64/tools/cpucaps                |   2 +
>  drivers/perf/apple_m1_cpu_pmu.c         | 101 +++++++++++++----
>  include/kvm/arm_pmu.h                   |  12 +--
>  include/linux/perf/arm_pmu.h            |   4 +
>  15 files changed, 301 insertions(+), 104 deletions(-)
> 
> 
> base-commit: 0ad2507d5d93f39619fc42372c347d6006b64319

I'm quite happy with the way this looks now (well, apart from patch
#9, but that's not something you can fix...).

Reviewed-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.