linux-kernel - Re: [PATCH 05/15] gpio: bd9571mwv: use new line value setter callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd86f1fe-8cd5-40f3-b06a-ed48a3ae5d5f@gmail.com>
Date: Mon, 10 Mar 2025 15:21:16 +0200
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Bartosz Golaszewski <brgl@...ev.pl>, Ray Jui <rjui@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>,
 Linus Walleij <linus.walleij@...aro.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Scott Branden <sbranden@...adcom.com>,
 Marek Vasut <marek.vasut+renesas@...il.com>, Michael Buesch <m@...s.ch>,
 Thomas Richard <thomas.richard@...tlin.com>,
 Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
 Benson Leung <bleung@...omium.org>, Guenter Roeck <groeck@...omium.org>,
 Andy Shevchenko <andy@...nel.org>,
 Support Opensource <support.opensource@...semi.com>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-renesas-soc@...r.kernel.org, chrome-platform@...ts.linux.dev,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 05/15] gpio: bd9571mwv: use new line value setter
 callbacks

On 10/03/2025 14:40, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. Convert the driver to using
> them.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

Reviewed-by: Matti Vaittinen <mazziesaccount@...il.com>

Thanks!

> ---
>   drivers/gpio/gpio-bd9571mwv.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio-bd9571mwv.c
> index 9a4d55f703bb..8df1361e3e84 100644
> --- a/drivers/gpio/gpio-bd9571mwv.c
> +++ b/drivers/gpio/gpio-bd9571mwv.c
> @@ -72,13 +72,13 @@ static int bd9571mwv_gpio_get(struct gpio_chip *chip, unsigned int offset)
>   	return val & BIT(offset);
>   }
>   
> -static void bd9571mwv_gpio_set(struct gpio_chip *chip, unsigned int offset,
> +static int bd9571mwv_gpio_set(struct gpio_chip *chip, unsigned int offset,
>   			      int value)
>   {
>   	struct bd9571mwv_gpio *gpio = gpiochip_get_data(chip);
>   
> -	regmap_update_bits(gpio->regmap, BD9571MWV_GPIO_OUT,
> -			   BIT(offset), value ? BIT(offset) : 0);
> +	return regmap_update_bits(gpio->regmap, BD9571MWV_GPIO_OUT,
> +				  BIT(offset), value ? BIT(offset) : 0);
>   }
>   
>   static const struct gpio_chip template_chip = {
> @@ -88,7 +88,7 @@ static const struct gpio_chip template_chip = {
>   	.direction_input	= bd9571mwv_gpio_direction_input,
>   	.direction_output	= bd9571mwv_gpio_direction_output,
>   	.get			= bd9571mwv_gpio_get,
> -	.set			= bd9571mwv_gpio_set,
> +	.set_rv			= bd9571mwv_gpio_set,
>   	.base			= -1,
>   	.ngpio			= 2,
>   	.can_sleep		= true,
>