linux-kernel - Re: [PATCH RFT] gpio: cdev: use raw notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MfESnTFU1mRDs8nW7BE+y=xTWGuN8s-yEg9ningmsXpvw@mail.gmail.com>
Date: Tue, 11 Mar 2025 15:21:58 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: David Jander <david@...tonic.nl>
Cc: Kent Gibson <warthog618@...il.com>, Linus Walleij <linus.walleij@...aro.org>, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH RFT] gpio: cdev: use raw notifier

On Tue, Mar 11, 2025 at 2:54 PM David Jander <david@...tonic.nl> wrote:
>
> On Tue, 11 Mar 2025 14:19:40 +0100
> Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > Atomic notifiers call rcu_synchronize() in
> > atomic_notifier_chain_unregister() causing a considerable delay in some
> > circumstances. Replace the atomic notifier with the raw variant and
> > provide synchronization with a read-write spinlock.
> >
> > Fixes: fcc8b637c542 ("gpiolib: switch the line state notifier to atomic")
> > Reported-by: David Jander <david@...tonic.nl>
> > Closes: https://lore.kernel.org/all/20250311110034.53959031@erd003.prtnl/
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > ---
>
> Tested-by: David Jander <david@...tonic.nl>
>
> Thanks!
>
> Seems to work correctly under some basic testing.
>

Thanks for testing, I'll improve the commit message and resend with your tag.

Bart