linux-kernel - Re: [PATCH 0/5] printk: renaming some suspend/resume functions and one fix for unblanking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a8b7634b123e82c3eaf278a5944feafd91279cc.camel@suse.com>
Date: Tue, 11 Mar 2025 11:41:14 -0300
From: Marcos Paulo de Souza <mpdesouza@...e.com>
To: Petr Mladek <pmladek@...e.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Eric Biederman	
 <ebiederm@...ssion.com>, "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown
	 <len.brown@...el.com>, Pavel Machek <pavel@....cz>, Steven Rostedt	
 <rostedt@...dmis.org>, John Ogness <john.ogness@...utronix.de>, Sergey
 Senozhatsky <senozhatsky@...omium.org>, Todd E Brandt
 <todd.e.brandt@...ux.intel.com>, Jiri Slaby	 <jirislaby@...nel.org>,
 linux-kernel@...r.kernel.org, kexec@...ts.infradead.org, 
	linux-pm@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 0/5] printk: renaming some suspend/resume functions and
 one fix for unblanking

On Tue, 2025-03-11 at 13:40 +0100, Petr Mladek wrote:
> On Tue 2025-03-11 11:38:00, Petr Mladek wrote:
> > On Wed 2025-02-26 16:59:00, Marcos Paulo de Souza wrote:
> > > Hello, I've being working on some patches that help to clarify
> > > the suspend/resume
> > > of printk machinery. The last patch on this patchset address one
> > > issue regarding
> > > suspended consoles and blanking.
> > > 
> > > This is a part one patchset that I would like to see merged
> > > before I send more patches
> > > that will rework the suspend flag (a global suspend flag istead
> > > of per console) and
> > > the removal of CON_ENABLED flag later on (I've created a function
> > > that will forcibly)
> > > register the console instead of using this flag.
> > > 
> > > Please review!
> > > 
> > > Signed-off-by: Marcos Paulo de Souza <mpdesouza@...e.com>
> > 
> > Looks good to me. I could fix the typos when pushing.
> > 
> > Well, there is one more thing. It seems that the simple graphic
> > logger
> > was merged for 6.14-rc1. And the console_stop()/console_start() API
> > is used also in drivers/gpu/drm/clients/drm_log.c.
> > 
> > It is actually the code which motivated this rename, as already
> > pointed out by John, see
> > https://lore.kernel.org/lkml/ZyoNZfLT6tlVAWjO@pathway.suse.cz/
> > 
> > Well, I am going to update these two locations when pushing this
> > as well. Let's just get this change done.
> 
> And I did as mentioned above.
> 
> JFYI, the patcheset has been committed into printk/linux.git,
> branch for-6.15-console-suspend-api-cleanup.

Thanks to all reviewers and to you Petr for taking the patches and
adjusting the typos!

> 
> Best Regards,
> Petr