linux-kernel - Re: [PATCH v2 07/15] nvmet-fcloop: update refs on tfcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48b56e21-2ccf-42ad-83ff-3cd97415e661@flourine.local>
Date: Tue, 11 Mar 2025 16:06:26 +0100
From: Daniel Wagner <dwagner@...e.de>
To: Daniel Wagner <wagi@...nel.org>
Cc: James Smart <james.smart@...adcom.com>, Christoph Hellwig <hch@....de>, 
	Sagi Grimberg <sagi@...mberg.me>, Chaitanya Kulkarni <kch@...dia.com>, 
	Hannes Reinecke <hare@...e.de>, Keith Busch <kbusch@...nel.org>, linux-nvme@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 07/15] nvmet-fcloop: update refs on tfcp_req

On Tue, Mar 11, 2025 at 11:11:33AM +0100, Daniel Wagner wrote:
> @@ -930,6 +932,8 @@ fcloop_fcp_req_release(struct nvmet_fc_target_port *tgtport,
>  {
>  	struct fcloop_fcpreq *tfcp_req = tgt_fcp_req_to_fcpreq(tgt_fcpreq);
>  
> +	if (!fcloop_tfcp_req_get(tfcp_req))
> +		return;
>  	queue_work(nvmet_wq, &tfcp_req->tio_done_work);
>  }

The ref is already taken in fcloop_fcp_req, so this is wrong and is the
reason for memory leak I observed.