[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d2a3328e-c8b1-4697-9a97-c198fe672f40@redhat.com>
Date: Tue, 11 Mar 2025 11:07:03 -0400
From: Waiman Long <llong@...hat.com>
To: Michal Koutný <mkoutny@...e.com>,
cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Tejun Heo <tj@...nel.org>, Johannes Weiner <hannes@...xchg.org>
Subject: Re: [PATCH v2 02/11] cgroup/cpuset-v1: Add deprecation messages to
memory_spread_page and memory_spread_slab
On 3/11/25 8:36 AM, Michal Koutný wrote:
> There is MPOL_INTERLEAVE for user explicit allocations.
> Deprecate spreading of allocations that users carry out unwittingly.
> Use straight warning level for slab spreading since such a knob is
> unnecessarily intertwined with slab allocator.
>
> Signed-off-by: Michal Koutný <mkoutny@...e.com>
> ---
> kernel/cgroup/cpuset-v1.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/cgroup/cpuset-v1.c b/kernel/cgroup/cpuset-v1.c
> index 9d47b20c03c4b..fea8a0cb7ae1d 100644
> --- a/kernel/cgroup/cpuset-v1.c
> +++ b/kernel/cgroup/cpuset-v1.c
> @@ -441,9 +441,11 @@ static int cpuset_write_u64(struct cgroup_subsys_state *css, struct cftype *cft,
> cpuset_memory_pressure_enabled = !!val;
> break;
> case FILE_SPREAD_PAGE:
> + pr_info_once("cpuset.%s is deprecated\n", cft->name);
> retval = cpuset_update_flag(CS_SPREAD_PAGE, cs, val);
> break;
> case FILE_SPREAD_SLAB:
> + pr_warn_once("cpuset.%s is deprecated\n", cft->name);
> retval = cpuset_update_flag(CS_SPREAD_SLAB, cs, val);
> break;
> default:
Acked-by: Waiman Long <longman@...hat.com>
Powered by blists - more mailing lists