linux-kernel - [PATCH] fpga: bridge: incorrect set to clear freeze_illegal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250311151601.12264-1-tanmay.kathpalia@altera.com>
Date: Tue, 11 Mar 2025 08:16:01 -0700
From: Tanmay Kathpalia <tanmay.kathpalia@...era.com>
To: mdf@...nel.org,
	hao.wu@...el.com,
	yilun.xu@...el.com
Cc: trix@...hat.com,
	linux-fpga@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	tanmay.kathpalia@...era.com,
	stable@...r.kernel.org,
	Chiau Ee Chew <chiau.ee.chew@...el.com>
Subject: [PATCH] fpga: bridge: incorrect set to clear freeze_illegal_request register

A Partial Region Controller can be connected to one or more
Freeze Bridge. Each Freeze Bridge has an illegal_request
bit represented in the freeze_illegal_request register.
Thus, instead of just set to clear the illegal_request bit
for first Freeze Bridge, we need to ensure the set to clear
action is applied to which ever Freeze Bridge that has
occurrence of illegal request.

Fixes: ca24a648f535 ("fpga: add altera freeze bridge support")
Signed-off-by: Chiau Ee Chew <chiau.ee.chew@...el.com>
Signed-off-by: Tanmay Kathpalia <tanmay.kathpalia@...era.com>
---
 drivers/fpga/altera-freeze-bridge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/altera-freeze-bridge.c b/drivers/fpga/altera-freeze-bridge.c
index 594693ff786e..23e8b2b54355 100644
--- a/drivers/fpga/altera-freeze-bridge.c
+++ b/drivers/fpga/altera-freeze-bridge.c
@@ -52,7 +52,7 @@ static int altera_freeze_br_req_ack(struct altera_freeze_br_data *priv,
 		if (illegal) {
 			dev_err(dev, "illegal request detected 0x%x", illegal);
 
-			writel(1, csr_illegal_req_addr);
+			writel(illegal, csr_illegal_req_addr);
 
 			illegal = readl(csr_illegal_req_addr);
 			if (illegal)
-- 
2.19.0