linux-kernel - Re: [PATCH RFC NOT TESTED 0/2] PCI: artpec6: Try to clean up artpec6_pcie_cpu_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174170613961.3566466.13045709851799071104.robh@kernel.org>
Date: Tue, 11 Mar 2025 10:19:30 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Jesper Nilsson <jesper.nilsson@...s.com>
Cc: Frank Li <Frank.Li@....com>, devicetree@...r.kernel.org, 
 Conor Dooley <conor+dt@...nel.org>, linux-pci@...r.kernel.org, 
 linux-arm-kernel@...s.com, linux-kernel@...r.kernel.org, 
 Lars Persson <lars.persson@...s.com>, 
 Lorenzo Pieralisi <lpieralisi@...nel.org>, 
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, 
 Krzysztof Wilczyński <kw@...ux.com>, 
 Bjorn Helgaas <bhelgaas@...gle.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>
Subject: Re: [PATCH RFC NOT TESTED 0/2] PCI: artpec6: Try to clean up
 artpec6_pcie_cpu_addr_fixup()


On Wed, 05 Mar 2025 16:33:18 +0100, Jesper Nilsson wrote:
> Hi Frank,
> 
> I'm the current maintainer of this driver. As Niklas Cassel wrote in
> another email, artpec-7 was supposed to be upstreamed, as it is in most
> parts identical to the artpec-6, but reality got in the way. I don't
> think there is very much left to support it at the same level as artpec-6,
> but give me some time to see if the best thing is to drop the artpec-7
> support as Niklas suggested.
> 
> Unfortunately, I'm travelling right now and don't have access to any
> of my boards. I'll perform some testing next week when I'm back and
> help to clean this up.
> 
> Best regards,
> 
> /Jesper
> 
> 
> On Tue, Mar 04, 2025 at 12:49:34PM -0500, Frank Li wrote:
> > This patches basic on
> > https://lore.kernel.org/imx/20250128-pci_fixup_addr-v9-0-3c4bb506f665@nxp.com/
> >
> > I have not hardware to test and there are not axis,artpec7-pcie in kernel
> > tree.
> >
> > Look for driver owner, who help test this and start move forward to remove
> > cpu_addr_fixup() work.
> >
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> > Frank Li (2):
> >       ARM: dts: artpec6: Move PCIe nodes under bus@...00000
> >       PCI: artpec6: Use use_parent_dt_ranges and clean up artpec6_pcie_cpu_addr_fixup()
> >
> >  arch/arm/boot/dts/axis/artpec6.dtsi       | 92 +++++++++++++++++--------------
> >  drivers/pci/controller/dwc/pcie-artpec6.c | 20 +------
> >  2 files changed, 52 insertions(+), 60 deletions(-)
> > ---
> > base-commit: 1552be4855dacca5ea39b15b1ef0b96c91dbea0d
> > change-id: 20250304-axis-6d12970976b4
> >
> > Best regards,
> > ---
> > Frank Li <Frank.Li@....com>
> 
> /^JN - Jesper Nilsson
> --
>                Jesper Nilsson -- jesper.nilsson@...s.com
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/axis/' for Z8huvkENIBxyPKJv@...s.com:

arch/arm/boot/dts/axis/artpec6-devboard.dtb: /bus@...00000/pcie@...50000: failed to match any schema with compatible: ['axis,artpec6-pcie', 'snps,dw-pcie']
arch/arm/boot/dts/axis/artpec6-devboard.dtb: /bus@...00000/pcie_ep@...50000: failed to match any schema with compatible: ['axis,artpec6-pcie-ep', 'snps,dw-pcie']