linux-kernel - Re: [PATCH v3 1/8] perf sched stats: Add record and rawdump support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56db239f-77db-4b78-9928-8e7cf4e8d793@web.de>
Date: Tue, 11 Mar 2025 17:19:53 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Swapnil Sapkal <swapnil.sapkal@....com>,
 Ravi Bangoria <ravi.bangoria@....com>, linux-perf-users@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Adrian Hunter <adrian.hunter@...el.com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Ananth Narayan <ananth.narayan@....com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>, Chen Yu <yu.c.chen@...el.com>,
 David Vernet <void@...ifault.com>, "Gautham R. Shenoy"
 <gautham.shenoy@....com>, Ian Rogers <irogers@...gle.com>,
 Ingo Molnar <mingo@...hat.com>, James Clark <james.clark@....com>,
 James Clark <james.clark@...aro.org>, Jiri Olsa <jolsa@...nel.org>,
 Juri Lelli <juri.lelli@...hat.com>, Kan Liang <kan.liang@...ux.intel.com>,
 K Prateek Nayak <kprateek.nayak@....com>, Mark Rutland
 <mark.rutland@....com>, Namhyung Kim <namhyung@...nel.org>,
 Peter Zijlstra <peterz@...radead.org>, Sandipan Das <sandipan.das@....com>,
 Santosh Shukla <Santosh.Shukla@....com>,
 Shrikanth Hegde <sshegde@...ux.ibm.com>, Steven Rostedt
 <rostedt@...dmis.org>, Tejun Heo <tj@...nel.org>,
 Vincent Guittot <vincent.guittot@...aro.org>,
 Yang Jihong <yangjihong@...edance.com>
Subject: Re: [PATCH v3 1/8] perf sched stats: Add record and rawdump support

…
> +++ b/tools/perf/util/event.c
…
> +size_t perf_event__fprintf_schedstat_cpu(union perf_event *event, FILE *fp)
> +{
…
> +	size_t size = 0;
> +
> +	size = fprintf(fp, "\ncpu%u ", cs->cpu);

I find an other code variant more succinct.

+	size_t size = fprintf(fp, "\ncpu%u ", cs->cpu);

Would you like to care for more complete error detection and corresponding
exception handling?
https://cwe.mitre.org/data/definitions/252.html

Regards,
Markus