linux-kernel - Re: [PATCH v2] kbuild: exclude .rodata.(cst|str)* when building ranges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQe5ZEd17v=zdP9xNMXFXa=Zjh=YUww2+_4Qerh=CdQOQ@mail.gmail.com>
Date: Wed, 12 Mar 2025 02:28:06 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Kris Van Hees <kris.van.hees@...cle.com>
Cc: linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org, 
	linux-modules@...r.kernel.org, linux-trace-kernel@...r.kernel.org, 
	Nick Alcock <nick.alcock@...cle.com>, Alan Maguire <alan.maguire@...cle.com>, 
	Steven Rostedt <rostedt@...dmis.org>, Sam James <sam@...too.org>, 
	Luis Chamberlain <mcgrof@...nel.org>, Masami Hiramatsu <mhiramat@...nel.org>, 
	Nick Desaulniers <ndesaulniers@...gle.com>, Jiri Olsa <olsajiri@...il.com>, 
	Elena Zannoni <elena.zannoni@...cle.com>, Daniel Gomez <da.gomez@...sung.com>, stable@...r.kernel.org, 
	Jack Vogel <jack.vogel@...cle.com>
Subject: Re: [PATCH v2] kbuild: exclude .rodata.(cst|str)* when building ranges

On Sat, Mar 8, 2025 at 1:54 AM Kris Van Hees <kris.van.hees@...cle.com> wrote:
>
> The .rodata.(cst|str)* sections are often resized during the final
> linking and since these sections do not cover actual symbols there is
> no need to include them in the modules.builtin.ranges data.
>
> When these sections were included in processing and resizing occurred,
> modules were reported with ranges that extended beyond their true end,
> causing subsequent symbols (in address order) to be associated with
> the wrong module.
>
> Fixes: 5f5e7344322f ("kbuild: generate offset range data for builtin modules")
> Cc: stable@...r.kernel.org
> Signed-off-by: Kris Van Hees <kris.van.hees@...cle.com>
> Reviewed-by: Jack Vogel <jack.vogel@...cle.com>
> ---

Applied to linux-kbuild. Thanks.

>  scripts/generate_builtin_ranges.awk | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/scripts/generate_builtin_ranges.awk b/scripts/generate_builtin_ranges.awk
> index b9ec761b3bef..d4bd5c2b998c 100755
> --- a/scripts/generate_builtin_ranges.awk
> +++ b/scripts/generate_builtin_ranges.awk
> @@ -282,6 +282,11 @@ ARGIND == 2 && !anchor && NF == 2 && $1 ~ /^0x/ && $2 !~ /^0x/ {
>  # section.
>  #
>  ARGIND == 2 && sect && NF == 4 && /^ [^ \*]/ && !($1 in sect_addend) {
> +       # There are a few sections with constant data (without symbols) that
> +       # can get resized during linking, so it is best to ignore them.
> +       if ($1 ~ /^\.rodata\.(cst|str)[0-9]/)
> +               next;
> +
>         if (!($1 in sect_base)) {
>                 sect_base[$1] = base;
>
> --
> 2.45.2
>


-- 
Best Regards
Masahiro Yamada