linux-kernel - Re: [RFC] misc: bcm-vk: avoid -Wflex-array-member-not-at-end warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9188b3d1-ee61-c1d1-f06e-854ffd2ccff7@broadcom.com>
Date: Tue, 11 Mar 2025 10:20:05 -0700
From: Scott Branden <scott.branden@...adcom.com>
To: "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [RFC] misc: bcm-vk: avoid -Wflex-array-member-not-at-end warning

Hi Gustavo,

On 2025-03-11 01:01, Gustavo A. R. Silva wrote:
> Hi all,
> 
> I'm trying to fix the following warning:
> 
> drivers/misc/bcm-vk/bcm_vk.h:415:32: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> 
> after a quick look, I don't see any code directly using the flexible
> array `data[]`, so this patch should probably suffice:
> 
> diff --git a/drivers/misc/bcm-vk/bcm_vk.h b/drivers/misc/bcm-vk/bcm_vk.h
> index 386884c2a263..9344c2366a4b 100644
> --- a/drivers/misc/bcm-vk/bcm_vk.h
> +++ b/drivers/misc/bcm-vk/bcm_vk.h
> @@ -311,7 +311,6 @@ struct bcm_vk_peer_log {
>          u32 wr_idx;
>          u32 buf_size;
>          u32 mask;
> -       char data[];
>   };
> 
> What do you think?
If it is changed to data[0] does the warning go away?  If not, you could 
remove it or change the code to use it instead of the sizeof used to
calculate peer offset.
> 
> Thanks
> --
> Gustavo