linux-kernel - Re: [PATCH 1/4] dt-bindings: media: qcom,sm8550-iris: update power domain name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <203ea0bb-c53c-389e-db12-b41773c0ff5d@quicinc.com>
Date: Wed, 12 Mar 2025 00:49:38 +0530
From: Vikash Garodia <quic_vgarodia@...cinc.com>
To: Dmitry Baryshkov <lumag@...nel.org>
CC: Dikshita Agarwal <quic_dikshita@...cinc.com>,
        Abhinav Kumar
	<quic_abhinavk@...cinc.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "Rob
 Herring" <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        "Conor
 Dooley" <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        "Konrad Dybcio" <konradybcio@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-media@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] dt-bindings: media: qcom,sm8550-iris: update power
 domain name


On 3/11/2025 9:05 PM, Dmitry Baryshkov wrote:
> On Tue, Mar 11, 2025 at 08:41:01PM +0530, Vikash Garodia wrote:
>>
>> On 3/11/2025 8:37 PM, Dmitry Baryshkov wrote:
>>> On Tue, Mar 11, 2025 at 05:33:53PM +0530, Vikash Garodia wrote:
>>>> Not all platforms has a collapsible mx, so use the more generic naming
>>>> of mx in the binding.
>>>
>>> I guess, it wasn't even tested...
>> Not sure what made you guess so, let me check why my binding checker did not
>> catch the bot reported warning.
> 
> Obvious: you are changing the bindings in a non-backwards compatible
> way, but you are not changing the example in the same file (and
> obviously you are not changing the DTs), which means that this wasn't
> tested.
> 
> Hint: you can use enum [mx, mxc] instead of const. That would make it
> backwards compatible.
Currently there are no user of this binding. Given that either of MX or MXC are
same connection to video hardware, just that one is collapsible, it would be
good to replace the existing element instead of enum.

Regards,
Vikash
> 
>> Regards,
>> Vikash
>>>
>>>>
>>>> Signed-off-by: Vikash Garodia <quic_vgarodia@...cinc.com>
>>>> ---
>>>>  Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
>>>> index e424ea84c211f473a799481fd5463a16580187ed..440a0d7cdfe19a1ccedefc207d96b26eed5d6630 100644
>>>> --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
>>>> +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
>>>> @@ -28,7 +28,7 @@ properties:
>>>>      items:
>>>>        - const: venus
>>>>        - const: vcodec0
>>>> -      - const: mxc
>>>> +      - const: mx
>>>>        - const: mmcx
>>>>  
>>>>    clocks:
>>>>
>>>> -- 
>>>> 2.34.1
>>>>
>>>
>