[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Z9CNzt9VAjFrLPBT@slm.duckdns.org>
Date: Tue, 11 Mar 2025 09:23:58 -1000
From: Tejun Heo <tj@...nel.org>
To: Michal Koutný <mkoutny@...e.com>
Cc: cgroups@...r.kernel.org, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
linux-mm@...ck.org, Josef Bacik <josef@...icpanda.com>,
Waiman Long <longman@...hat.com>, Jonathan Corbet <corbet@....net>,
Andrew Morton <akpm@...ux-foundation.org>,
Shakeel Butt <shakeel.butt@...ux.dev>,
Roman Gushchin <roman.gushchin@...ux.dev>,
Johannes Weiner <hannes@...xchg.org>,
Muchun Song <muchun.song@...ux.dev>,
Michal Hocko <mhocko@...nel.org>, Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH v2 00/11] cgroup v1 deprecation messages
On Tue, Mar 11, 2025 at 01:36:17PM +0100, Michal Koutný wrote:
> Memory controller had begun to print warning messages when using some
> attributes that do no have a counterpart in its cgroup v2
> implementation. This is informative to users who run (unwittingly) on v1
> or to distros that run v1 (they can learn about such users or prepare
> for disabling v1 configs).
>
> I consider the deprecated files in three categories:
> - RE) replacement exists,
> - DN) dropped as non-ideal concept (e.g. non-hierarchical resources),
> - NE) not evaluated (yet).
>
> For RE, I added the replacement into the warning message, DN have only a
> plain deprecation message and I marked the commits with NE as RFC.
> Also I'd be happy if you would point out some forgotten knobs that'd
> deserve similar warnings.
>
> The level of messages is info to avoid too much noise (may be increased
> in future when there are fewer users). Some knobs from DN have warn
> level.
>
> The net_cls and net_prio controllers that only exist on v1 hierarchies
> have no straightforward action for users (replacement would rely on net
> NS or eBPF), so messages for their usage are omitted, although it'd be
> good to eventually retire that code in favor of aforementioned.
>
> At the end are some cleanup patches I encountered en route.
Applied to cgroup/for-6.15.
Thanks.
--
tejun
Powered by blists - more mailing lists