| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <Z9CbQaapTggFitFY@mini-arch>
Date: Tue, 11 Mar 2025 13:21:21 -0700
From: Stanislav Fomichev <stfomichev@...il.com>
To: syzbot <syzbot+2d6285cc150f4ee51ef9@...kaller.appspotmail.com>
Cc: davem@...emloft.net, edumazet@...gle.com, horms@...nel.org,
kuba@...nel.org, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, pabeni@...hat.com,
syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [net?] possible deadlock in dev_set_mac_address
On 03/11, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit: 40587f749df2 Merge branch 'enic-enable-32-64-byte-cqes-and..
> git tree: net-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=1420d478580000
> kernel config: https://syzkaller.appspot.com/x/.config?x=ca99d9d1f4a8ecfa
> dashboard link: https://syzkaller.appspot.com/bug?extid=2d6285cc150f4ee51ef9
> compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
>
> Unfortunately, I don't have any reproducer for this issue yet.
>
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/6d02993a9211/disk-40587f74.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/2c8b300bf362/vmlinux-40587f74.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/2d5be21882cf/bzImage-40587f74.xz
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+2d6285cc150f4ee51ef9@...kaller.appspotmail.com
>
> ======================================================
> WARNING: possible circular locking dependency detected
> 6.14.0-rc5-syzkaller-01183-g40587f749df2 #0 Not tainted
> ------------------------------------------------------
> syz.3.4651/21867 is trying to acquire lock:
> ffff88805e634d28 (&dev_instance_lock_key#12){+.+.}-{4:4}, at: netdev_lock include/linux/netdevice.h:2731 [inline]
> ffff88805e634d28 (&dev_instance_lock_key#12){+.+.}-{4:4}, at: dev_set_mac_address+0x2a/0x50 net/core/dev_api.c:302
>
> but task is already holding lock:
> ffff88807de0cd28 (&dev_instance_lock_key#2){+.+.}-{4:4}, at: netdev_lock include/linux/netdevice.h:2731 [inline]
> ffff88807de0cd28 (&dev_instance_lock_key#2){+.+.}-{4:4}, at: do_setlink+0xa94/0x40f0 net/core/rtnetlink.c:3094
>
> which lock already depends on the new lock.
>
>
> the existing dependency chain (in reverse order) is:
>
> -> #2 (&dev_instance_lock_key#2){+.+.}-{4:4}:
> lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851
> __mutex_lock_common kernel/locking/mutex.c:585 [inline]
> __mutex_lock+0x19c/0x1010 kernel/locking/mutex.c:730
> netdev_lock include/linux/netdevice.h:2731 [inline]
> netif_set_up net/core/dev.h:143 [inline]
> __dev_open+0x5cb/0x8a0 net/core/dev.c:1651
> netif_open+0xae/0x1b0 net/core/dev.c:1667
> dev_open+0x13e/0x260 net/core/dev_api.c:191
> team_port_add drivers/net/team/team_core.c:1230 [inline]
> team_add_slave+0xabe/0x28a0 drivers/net/team/team_core.c:1989
> do_set_master+0x579/0x730 net/core/rtnetlink.c:2943
> do_setlink+0xfee/0x40f0 net/core/rtnetlink.c:3149
> rtnl_changelink net/core/rtnetlink.c:3759 [inline]
> __rtnl_newlink net/core/rtnetlink.c:3918 [inline]
> rtnl_newlink+0x15a6/0x1d90 net/core/rtnetlink.c:4055
> rtnetlink_rcv_msg+0x791/0xcf0 net/core/rtnetlink.c:6945
> netlink_rcv_skb+0x206/0x480 net/netlink/af_netlink.c:2534
> netlink_unicast_kernel net/netlink/af_netlink.c:1313 [inline]
> netlink_unicast+0x7f6/0x990 net/netlink/af_netlink.c:1339
> netlink_sendmsg+0x8de/0xcb0 net/netlink/af_netlink.c:1883
> sock_sendmsg_nosec net/socket.c:709 [inline]
> __sock_sendmsg+0x221/0x270 net/socket.c:724
> ____sys_sendmsg+0x53a/0x860 net/socket.c:2564
> ___sys_sendmsg net/socket.c:2618 [inline]
> __sys_sendmsg+0x269/0x350 net/socket.c:2650
> do_syscall_x64 arch/x86/entry/common.c:52 [inline]
> do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
> entry_SYSCALL_64_after_hwframe+0x77/0x7f
>
> -> #1 (team->team_lock_key#2){+.+.}-{4:4}:
> lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851
> __mutex_lock_common kernel/locking/mutex.c:585 [inline]
> __mutex_lock+0x19c/0x1010 kernel/locking/mutex.c:730
> team_set_mac_address+0x122/0x280 drivers/net/team/team_core.c:1817
> netif_set_mac_address+0x327/0x510 net/core/dev.c:9605
> do_setlink+0xaa6/0x40f0 net/core/rtnetlink.c:3095
> rtnl_changelink net/core/rtnetlink.c:3759 [inline]
> __rtnl_newlink net/core/rtnetlink.c:3918 [inline]
> rtnl_newlink+0x15a6/0x1d90 net/core/rtnetlink.c:4055
> rtnetlink_rcv_msg+0x791/0xcf0 net/core/rtnetlink.c:6945
> netlink_rcv_skb+0x206/0x480 net/netlink/af_netlink.c:2534
> netlink_unicast_kernel net/netlink/af_netlink.c:1313 [inline]
> netlink_unicast+0x7f6/0x990 net/netlink/af_netlink.c:1339
> netlink_sendmsg+0x8de/0xcb0 net/netlink/af_netlink.c:1883
> sock_sendmsg_nosec net/socket.c:709 [inline]
> __sock_sendmsg+0x221/0x270 net/socket.c:724
> __sys_sendto+0x363/0x4c0 net/socket.c:2178
> __do_sys_sendto net/socket.c:2185 [inline]
> __se_sys_sendto net/socket.c:2181 [inline]
> __x64_sys_sendto+0xde/0x100 net/socket.c:2181
> do_syscall_x64 arch/x86/entry/common.c:52 [inline]
> do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
> entry_SYSCALL_64_after_hwframe+0x77/0x7f
>
> -> #0 (&dev_instance_lock_key#12){+.+.}-{4:4}:
> check_prev_add kernel/locking/lockdep.c:3163 [inline]
> check_prevs_add kernel/locking/lockdep.c:3282 [inline]
> validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3906
> __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5228
> lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851
> __mutex_lock_common kernel/locking/mutex.c:585 [inline]
> __mutex_lock+0x19c/0x1010 kernel/locking/mutex.c:730
> netdev_lock include/linux/netdevice.h:2731 [inline]
> dev_set_mac_address+0x2a/0x50 net/core/dev_api.c:302
> bond_set_mac_address+0x28e/0x830 drivers/net/bonding/bond_main.c:4903
> netif_set_mac_address+0x327/0x510 net/core/dev.c:9605
> do_setlink+0xaa6/0x40f0 net/core/rtnetlink.c:3095
> rtnl_changelink net/core/rtnetlink.c:3759 [inline]
> __rtnl_newlink net/core/rtnetlink.c:3918 [inline]
> rtnl_newlink+0x15a6/0x1d90 net/core/rtnetlink.c:4055
> rtnetlink_rcv_msg+0x791/0xcf0 net/core/rtnetlink.c:6945
> netlink_rcv_skb+0x206/0x480 net/netlink/af_netlink.c:2534
> netlink_unicast_kernel net/netlink/af_netlink.c:1313 [inline]
> netlink_unicast+0x7f6/0x990 net/netlink/af_netlink.c:1339
> netlink_sendmsg+0x8de/0xcb0 net/netlink/af_netlink.c:1883
> sock_sendmsg_nosec net/socket.c:709 [inline]
> __sock_sendmsg+0x221/0x270 net/socket.c:724
> ____sys_sendmsg+0x53a/0x860 net/socket.c:2564
> ___sys_sendmsg net/socket.c:2618 [inline]
> __sys_sendmsg+0x269/0x350 net/socket.c:2650
> do_syscall_x64 arch/x86/entry/common.c:52 [inline]
> do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
> entry_SYSCALL_64_after_hwframe+0x77/0x7f
>
> other info that might help us debug this:
>
> Chain exists of:
> &dev_instance_lock_key#12 --> team->team_lock_key#2 --> &dev_instance_lock_key#2
>
> Possible unsafe locking scenario:
>
> CPU0 CPU1
> ---- ----
> lock(&dev_instance_lock_key#2);
> lock(team->team_lock_key#2);
> lock(&dev_instance_lock_key#2);
> lock(&dev_instance_lock_key#12);
>
> *** DEADLOCK ***
>
> 2 locks held by syz.3.4651/21867:
> #0: ffffffff8fed6908 (rtnl_mutex){+.+.}-{4:4}, at: rtnl_lock net/core/rtnetlink.c:80 [inline]
> #0: ffffffff8fed6908 (rtnl_mutex){+.+.}-{4:4}, at: rtnl_nets_lock net/core/rtnetlink.c:341 [inline]
> #0: ffffffff8fed6908 (rtnl_mutex){+.+.}-{4:4}, at: rtnl_newlink+0xc4c/0x1d90 net/core/rtnetlink.c:4054
> #1: ffff88807de0cd28 (&dev_instance_lock_key#2){+.+.}-{4:4}, at: netdev_lock include/linux/netdevice.h:2731 [inline]
> #1: ffff88807de0cd28 (&dev_instance_lock_key#2){+.+.}-{4:4}, at: do_setlink+0xa94/0x40f0 net/core/rtnetlink.c:3094
>
> stack backtrace:
> CPU: 0 UID: 0 PID: 21867 Comm: syz.3.4651 Not tainted 6.14.0-rc5-syzkaller-01183-g40587f749df2 #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
> Call Trace:
> <TASK>
> __dump_stack lib/dump_stack.c:94 [inline]
> dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
> print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2076
> check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2208
> check_prev_add kernel/locking/lockdep.c:3163 [inline]
> check_prevs_add kernel/locking/lockdep.c:3282 [inline]
> validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3906
> __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5228
> lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851
> __mutex_lock_common kernel/locking/mutex.c:585 [inline]
> __mutex_lock+0x19c/0x1010 kernel/locking/mutex.c:730
> netdev_lock include/linux/netdevice.h:2731 [inline]
> dev_set_mac_address+0x2a/0x50 net/core/dev_api.c:302
> bond_set_mac_address+0x28e/0x830 drivers/net/bonding/bond_main.c:4903
> netif_set_mac_address+0x327/0x510 net/core/dev.c:9605
> do_setlink+0xaa6/0x40f0 net/core/rtnetlink.c:3095
> rtnl_changelink net/core/rtnetlink.c:3759 [inline]
> __rtnl_newlink net/core/rtnetlink.c:3918 [inline]
> rtnl_newlink+0x15a6/0x1d90 net/core/rtnetlink.c:4055
> rtnetlink_rcv_msg+0x791/0xcf0 net/core/rtnetlink.c:6945
> netlink_rcv_skb+0x206/0x480 net/netlink/af_netlink.c:2534
> netlink_unicast_kernel net/netlink/af_netlink.c:1313 [inline]
> netlink_unicast+0x7f6/0x990 net/netlink/af_netlink.c:1339
> netlink_sendmsg+0x8de/0xcb0 net/netlink/af_netlink.c:1883
> sock_sendmsg_nosec net/socket.c:709 [inline]
> __sock_sendmsg+0x221/0x270 net/socket.c:724
> ____sys_sendmsg+0x53a/0x860 net/socket.c:2564
> ___sys_sendmsg net/socket.c:2618 [inline]
> __sys_sendmsg+0x269/0x350 net/socket.c:2650
> do_syscall_x64 arch/x86/entry/common.c:52 [inline]
> do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
> entry_SYSCALL_64_after_hwframe+0x77/0x7f
> RIP: 0033:0x7fb6b198d169
> Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
> RSP: 002b:00007fb6af7d5038 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
> RAX: ffffffffffffffda RBX: 00007fb6b1ba6080 RCX: 00007fb6b198d169
> RDX: 0000000000040880 RSI: 0000400000000000 RDI: 0000000000000009
> RBP: 00007fb6b1a0e2a0 R08: 0000000000000000 R09: 0000000000000000
> R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
> R13: 0000000000000000 R14: 00007fb6b1ba6080 R15: 00007fff137bf0e8
> </TASK>
> bond0: entered promiscuous mode
> team0: entered promiscuous mode
> bond0: left allmulticast mode
> team0: left allmulticast mode
>
>
> ---
> This report is generated by a bot. It may contain errors.
> See https://goo.gl/tpsmEJ for more information about syzbot.
> syzbot engineers can be reached at syzkaller@...glegroups.com.
>
> syzbot will keep track of this issue. See:
> https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
>
> If the report is already addressed, let syzbot know by replying with:
> #syz fix: exact-commit-title
>
> If you want to overwrite report's subsystems, reply with:
> #syz set subsystems: new-subsystem
> (See the list of subsystem names on the web dashboard)
>
> If the report is a duplicate of another one, reply with:
> #syz dup: exact-subject-of-another-report
>
> If you want to undo deduplication, reply with:
> #syz undup
I think it should be addressed by https://lore.kernel.org/netdev/20250311084507.3978048-1-sdf@fomichev.me/
It is the same team_lock->netdev_ops vs netdev_ops->team_lock ordering issue:
rtnl_newlink
rtnl_changelink
do_setlink IFLA_MASTER lower
do_set_master
team_add_slave
team_lock
team_port_add
dev_open
dev_instance_lock#2 - for netdev_ops (not taken)
netif_open
__dev_open
netif_set_up
dev_instance_lock#2 - for non-netdev_ops (taken)
rtnl_newlink
__rtnl_newlink
rtnl_changelink
do_setlink IFLA_ADDRESS upper
dev_instace_lock - for non-netdev_ops (taken) <<< GONNA BE REPLACED BY DEV_ADDR_SEM
netif_set_mac_address
team_set_mac_address
team_lock
Will keep an eye on the dashboard..
Powered by blists - more mailing lists