linux-kernel - Re: [PATCH] x86/stackprotector: fix build failure with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMzpN2iDOdn_r2aFipfyx3yKSKcSkQ5U6BpZ84L7i_Q6LmXgbA@mail.gmail.com>
Date: Tue, 11 Mar 2025 17:47:42 -0400
From: Brian Gerst <brgerst@...il.com>
To: Oleg Nesterov <oleg@...hat.com>
Cc: Borislav Petkov <bp@...en8.de>, Ard Biesheuvel <ardb@...nel.org>, linux-kernel@...r.kernel.org, 
	x86@...nel.org, Ingo Molnar <mingo@...nel.org>, "H . Peter Anvin" <hpa@...or.com>, 
	Thomas Gleixner <tglx@...utronix.de>, Uros Bizjak <ubizjak@...il.com>, stable@...r.kernel.org, 
	Fangrui Song <i@...kray.me>, Nathan Chancellor <nathan@...nel.org>, Andy Lutomirski <luto@...nel.org>
Subject: Re: [PATCH] x86/stackprotector: fix build failure with CONFIG_STACKPROTECTOR=n

On Tue, Mar 11, 2025 at 5:42 PM Oleg Nesterov <oleg@...hat.com> wrote:
>
> On 03/11, Brian Gerst wrote:
> >
> > On Tue, Mar 11, 2025 at 3:24 PM Oleg Nesterov <oleg@...hat.com> wrote:
> > >
> > > OK. I'll update the subject/changelog to explain that this is only
> > > needed for the older binutils and send V2.
> >
> > With it conditional on CONFIG_STACKPROTECTOR, you can also drop PROVIDES().
>
> Sorry Brian, I don't understand this magic even remotely...
>
> Do you mean
>
>         -/* needed for Clang - see arch/x86/entry/entry.S */
>         -PROVIDE(__ref_stack_chk_guard = __stack_chk_guard);
>         +#ifdef CONFIG_STACKPROTECTOR
>         +__ref_stack_chk_guard = __stack_chk_guard;
>         +#endif
>
> ?
>
> Oleg.

Yes.  Also keep the comment about Clang.


Brian Gerst