linux-kernel - Re: [PATCH] wifi: mac80211: Add __nonstring annotations for unterminated strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202503111530.43283E3@keescook>
Date: Tue, 11 Mar 2025 15:36:42 -0700
From: Kees Cook <kees@...nel.org>
To: Johannes Berg <johannes@...solutions.net>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Kalle Valo <kvalo@...nel.org>, Julia Lawall <Julia.Lawall@...ia.fr>,
	En-Wei Wu <en-wei.wu@...onical.com>,
	Shaul Triebitz <shaul.triebitz@...el.com>,
	Alexander Wetzel <alexander@...zel-home.de>,
	Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	kernel test robot <lkp@...el.com>,
	Miri Korenblit <miriam.rachel.korenblit@...el.com>,
	linux-kernel@...r.kernel.org,
	syzbot+d6eb9cee2885ec06f5e3@...kaller.appspotmail.com,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] wifi: mac80211: Add __nonstring annotations for
 unterminated strings

On Tue, Mar 11, 2025 at 10:25:10AM +0100, Johannes Berg wrote:
> On Mon, 2025-03-10 at 15:23 -0700, Kees Cook wrote:
> > 
> >  drivers/net/wireless/virtual/virt_wifi.c     | 2 +-
> >  drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 2 +-
> > 
> 
> That's not mac80211?

Hrm, you're right. The automation I use for splitting up "treewide"
changes per subsystem tries to guess at a reasonable subject give a set
of files, based on historical git subject prefixes. And these two files
ended up grouped together because no more specific subsystem claimed
them.

It seems I should probably split this into two, as:

wifi: zd1211rw:
wifi: virt_wifi:

> Also, I have no idea how you came up with the CC list but it seems
> excessive. :)

It's based on my permutation of arguments to get_maintainers.pl that
seems to work best for splitting my "treewide" changes per subsystem:

        ccs = subprocess.run(["./scripts/get_maintainer.pl", "--email",
                              "--git-min-percent", "15",
                              "--git-since", '3-years-ago',
                              "--no-rolestats", patch.name],

-Kees

-- 
Kees Cook