linux-kernel - Re: [PATCH] scripts: Add git-resolve tool for full SHA-1 resolution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202503111547.1DDFF8E4E@keescook>
Date: Tue, 11 Mar 2025 15:48:04 -0700
From: Kees Cook <kees@...nel.org>
To: Sasha Levin <sashal@...nel.org>
Cc: workflows@...r.kernel.org, apw@...onical.com, conor@...nel.org,
	corbet@....net, dwaipayanray1@...il.com, geert+renesas@...der.be,
	gitster@...ox.com, horms@...nel.org, joe@...ches.com,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux@...mhuis.info, lukas.bulwahn@...il.com,
	miguel.ojeda.sandonis@...il.com, niklas.soderlund@...igine.com,
	torvalds@...ux-foundation.org, willy@...radead.org
Subject: Re: [PATCH] scripts: Add git-resolve tool for full SHA-1 resolution

On Tue, Mar 11, 2025 at 12:53:36PM -0400, Sasha Levin wrote:
> Introduce git-resolve.sh, a tool that resolves short git commit IDs to their
> full SHA-1 hash. This is particularly useful for navigating references in commit
> messages and verifying Fixes tags.
> 
> When faced with ambiguous commit IDs or imprecise references in messages,
> this tool can help by resolving commit hashes based on not just the ID
> itself but also the commit subject, making it more robust than standard
> git rev-parse.
> 
> This is especially valuable for maintainers who need to verify Fixes tags
> or cross-reference commits. Unlike proposals to add dates to Fixes tags
> (which would break existing tooling), this script provides a way to
> disambiguate commits without changing the established tag format.
> 
> The script includes several features:
> - Resolves short commit IDs to full SHA-1 hashes
> - Uses commit subjects to disambiguate between multiple potential matches
> - Supports wildcard patterns in subjects with ellipsis (...)
> - Provides a force mode to attempt resolution by subject when ID lookup fails
> - Includes comprehensive self-tests
> 
> Signed-off-by: Sasha Levin <sashal@...nel.org>

Nice! Thanks for incorporating the features from akpm's scripts, I think
that'll help a lot when resolving weird stuff. :)

Reviewed-by: Kees Cook <kees@...nel.org>

-- 
Kees Cook