linux-kernel - Re: [PATCH] i2c: cadence: fix call balance of id->clk handling routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <rbn5jxvmcl76n3grg3fzc3z5vqgmieixmrq3rkhbpdremlbeze@quqxmsszknfe>
Date: Tue, 11 Mar 2025 23:52:49 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Vitalii Mordan <mordan@...ras.ru>
Cc: Michal Simek <michal.simek@....com>, 
	Harini Katakam <harinik@...inx.com>, Wolfram Sang <wsa@...nel.org>, 
	Soren Brinkmann <soren.brinkmann@...inx.com>, linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Fedor Pchelkin <pchelkin@...ras.ru>, 
	Alexey Khoroshilov <khoroshilov@...ras.ru>, Vadim Mutilin <mutilin@...ras.ru>, lvc-project@...uxtesting.org
Subject: Re: [PATCH] i2c: cadence: fix call balance of id->clk handling
 routines

Hi Vitalii,

On Mon, Mar 03, 2025 at 05:08:05PM +0300, Vitalii Mordan wrote:
> If the clock id->clk was not enabled in cdns_i2c_probe(), it should not be
> disabled in any execution path. If the clock was not enabled, the probe
> function should return an error code.
> 
> Use the devm_clk_get_enabled() helper function to ensure proper call
> balance for id->clk.
> 
> Found by Linux Verification Center (linuxtesting.org) with Klever.
> 
> Fixes: df8eb5691c48 ("i2c: Add driver for Cadence I2C controller")
> Signed-off-by: Vitalii Mordan <mordan@...ras.ru>

Thanks for this patch, but it was already sent previously by
Michal and Manikanta.

Thanks,
Andi