linux-kernel - Re: [PATCH v2 1/2] scripts: generate_rust_analyzer.py: add missing include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=s8mtLQwWuKj+VER_rR2PzHv5JHEW5o026qvvidj6ZzA@mail.gmail.com>
Date: Wed, 12 Mar 2025 00:01:08 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Tamir Duberstein <tamird@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, Kees Cook <kees@...nel.org>, 
	Fiona Behrens <me@...enk.dev>, Martin Rodriguez Reboredo <yakoyoku@...il.com>, Asahi Lina <lina@...hilina.net>, 
	Boris-Chengbiao Zhou <bobo1239@....de>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] scripts: generate_rust_analyzer.py: add missing include_dirs

On Tue, Mar 11, 2025 at 11:48 PM Tamir Duberstein <tamird@...il.com> wrote:
>
> I don't follow this; there's a bindings crate at 8c4555ccc55c
> ("scripts: add `generate_rust_analyzer.py`") - at least as far as RA
> is concerned.

By "before being in mainline" I mean before Rust was in Linus' tree,
i.e. a long time ago in the old `rust` branch.

Back then, there was a period of time when there was no `bindings`
crate. At some point it was split from the `kernel` crate, which did
have the `include_dirs` for that reason, and at that moment the
`include_dirs` should have been moved too, but it wasn't.

So we ended up with `include_dirs` in the `kernel` crate for no reason
(because AFAICS it was not needed until we got
`generated_arch_static_branch_asm.rs`, but I haven't actually tested
that in RA) and missing it in the `bindings` one where it was actually
needed.

(I was trying to understand how we ended up here just to double-check
why we had things split like that)

> Yes, without it `generated_arch_static_branch_asm.rs` is not found by RA.

Thanks for confirming!

Cheers,
Miguel