linux-kernel - RE: [PATCH V2 3/3] tty: serial: lpuart: rename register variables more specifically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DB9PR04MB842943700539141A89FB116592D12@DB9PR04MB8429.eurprd04.prod.outlook.com>
Date: Tue, 11 Mar 2025 06:57:24 +0000
From: Sherry Sun <sherry.sun@....com>
To: Jiri Slaby <jirislaby@...nel.org>, "gregkh@...uxfoundation.org"
	<gregkh@...uxfoundation.org>
CC: "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, Shenwei Wang
	<shenwei.wang@....com>
Subject: RE: [PATCH V2 3/3] tty: serial: lpuart: rename register variables
 more specifically



> -----Original Message-----
> From: Jiri Slaby <jirislaby@...nel.org>
> Sent: Tuesday, March 11, 2025 11:51 AM
> To: Sherry Sun <sherry.sun@....com>; gregkh@...uxfoundation.org
> Cc: linux-serial@...r.kernel.org; linux-kernel@...r.kernel.org;
> imx@...ts.linux.dev; Shenwei Wang <shenwei.wang@....com>
> Subject: Re: [PATCH V2 3/3] tty: serial: lpuart: rename register variables more
> specifically
> 
> On 11. 03. 25, 4:33, Sherry Sun wrote:
> > There are many fuzzy register variables in the lpuart driver, such as
> > temp, tmp, val, reg. Let's give these register variables more specific
> > names.
> >
> > Signed-off-by: Sherry Sun <sherry.sun@....com>
> > ---
> >   drivers/tty/serial/fsl_lpuart.c | 220 ++++++++++++++++----------------
> >   1 file changed, 110 insertions(+), 110 deletions(-)
> >
> > diff --git a/drivers/tty/serial/fsl_lpuart.c
> > b/drivers/tty/serial/fsl_lpuart.c index f830b5a3ba8e..901c83461bfc
> > 100644
> > --- a/drivers/tty/serial/fsl_lpuart.c
> > +++ b/drivers/tty/serial/fsl_lpuart.c
> > @@ -441,36 +441,36 @@ static unsigned int
> > lpuart_get_baud_clk_rate(struct lpuart_port *sport)
> >
> >   static void lpuart_stop_tx(struct uart_port *port)
> >   {
> > -	unsigned char temp;
> > +	unsigned char cr2;
> 
> Overall looks good. In cases like these (there are many), you should have
> switched this to u8 in patch 1/3 too ;).

Hi Jiri,
Looks like lpuart driver needs more thorough clean. :)
Sure, will add u8 changes in V3.

Best Regards
Sherry