linux-kernel - Re: [PATCH] mmc: cb710: Fix an error handling path in cb710

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z8_goDqqhPFE4n3Y@qmqm.qmqm.pl>
Date: Tue, 11 Mar 2025 08:05:04 +0100
From: Michał Mirosław <mirq-linux@...e.qmqm.pl>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Pierre Ossman <pierre@...man.eu>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mmc: cb710: Fix an error handling path in cb710_probe()

On Sun, Mar 09, 2025 at 09:22:05AM +0100, Christophe JAILLET wrote:
> If an error occurs after a successful ida_alloc() call, it should be undone
> by a corresponding ida_free(), as already done in the remove function.
> 
> Add the missing call in the error handling path of cb710_probe().
> 
> Fixes: 5f5bac8272be ("mmc: Driver for CB710/720 memory card reader (MMC part)")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/misc/cb710/core.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Acked-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>