linux-kernel - RE: [PATCH v9 RESEND] wifi: mt76: mt7915: add wds support when wed is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f25427774f1147d995d9fd86da071ef3@realtek.com>
Date: Tue, 11 Mar 2025 08:29:00 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Shengyu Qu <wiagn233@...look.com>, Felix Fietkau <nbd@....name>,
        "lorenzo@...nel.org" <lorenzo@...nel.org>,
        "ryder.lee@...iatek.com"
	<ryder.lee@...iatek.com>,
        "shayne.chen@...iatek.com"
	<shayne.chen@...iatek.com>,
        "sean.wang@...iatek.com"
	<sean.wang@...iatek.com>,
        "johannes@...solutions.net"
	<johannes@...solutions.net>,
        "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>,
        "angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>,
        "miriam.rachel.korenblit@...el.com" <miriam.rachel.korenblit@...el.com>,
        "howard-yh.hsu@...iatek.com" <howard-yh.hsu@...iatek.com>,
        "greearb@...delatech.com" <greearb@...delatech.com>,
        "chui-hao.chiu@...iatek.com" <chui-hao.chiu@...iatek.com>,
        "mingyen.hsieh@...iatek.com" <mingyen.hsieh@...iatek.com>,
        "quic_adisi@...cinc.com" <quic_adisi@...cinc.com>,
        "sujuan.chen@...iatek.com"
	<sujuan.chen@...iatek.com>,
        "gustavoars@...nel.org" <gustavoars@...nel.org>,
        "bo.jiao@...iatek.com" <bo.jiao@...iatek.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>
Subject: RE: [PATCH v9 RESEND] wifi: mt76: mt7915: add wds support when wed is enabled

> >>
> >>    	mt76_connac_mcu_del_wtbl_all(&dev->mt76);
> >>
> >> -	if ((mtk_wed_device_active(&dev->mt76.mmio.wed) &&
> >> -	     is_mt7915(&dev->mt76)) ||
> >> -	    !mtk_wed_get_rx_capa(&dev->mt76.mmio.wed))
> >> -		mt7915_mcu_wa_cmd(dev, MCU_WA_PARAM_CMD(CAPABILITY), 0, 0, 0);
> >> +#if IS_ENABLED(CONFIG_NET_MEDIATEK_SOC_WED)
> >
> > In MT76, there are two styles:
> >    #if IS_ENABLED(CONFIG_NET_MEDIATEK_SOC_WED)
> >    #ifdef CONFIG_NET_MEDIATEK_SOC_WED
> >
> > I think both are correct. Just wonder why not making them consistent.
> Seems you didn't receive Felix's email, check this:
> https://lore.kernel.org/linux-wireless/71ed8398-4619-4793-804d-77cad36e7402@nbd.name/
> 

I was aware of this. Felix pointed out 'if (IS_ENABLED(CONFIG_NET_MEDIATEK_SOC_WED))'
will lead build error. But what I mentioned here were '#if' and
'#ifdef' (preprocess directive).

Anyway, ignore this.