linux-kernel - Re: [PATCH v4 8/8] imx_dsp_rproc: Use reset controller API to control the DSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEnQRZDeBkNYBNQwJL5LZgLK49siqomzyM_RDccdusJa22yiJA@mail.gmail.com>
Date: Tue, 11 Mar 2025 10:59:46 +0200
From: Daniel Baluta <daniel.baluta@...il.com>
To: Mathieu Poirier <mathieu.poirier@...aro.org>
Cc: Daniel Baluta <daniel.baluta@....com>, p.zabel@...gutronix.de, robh@...nel.org, 
	krzk+dt@...nel.org, shawnguo@...nel.org, devicetree@...r.kernel.org, 
	linux-remoteproc@...r.kernel.org, conor+dt@...nel.org, s.hauer@...gutronix.de, 
	kernel@...gutronix.de, festevam@...il.com, linux-kernel@...r.kernel.org, 
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
	andersson@...nel.org, Frank.Li@....com, peng.fan@....com, 
	laurentiu.mihalcea@....com, iuliana.prodan@....com, shengjiu.wang@....com
Subject: Re: [PATCH v4 8/8] imx_dsp_rproc: Use reset controller API to control
 the DSP

On Mon, Mar 10, 2025 at 5:43 PM Mathieu Poirier
<mathieu.poirier@...aro.org> wrote:
>
> Good day,
>
> On Wed, Mar 05, 2025 at 12:00:36PM +0200, Daniel Baluta wrote:
> > DSP on i.MX8MP doesn't have a direct reset line so according to hardware
> > design team in order to handle assert/deassert/reset functionality we
> > need to use a combination of control bits from two modules. Audio block
> > control module for Run/Stall control of the DSP and DAP module in order
> > to do software reset.
> >
> > Initial design accessed RunStall bits from audio block control using the
> > syscon interface but this got NACKed by community because of abusing the
> > syscon interface [1].
> >
> > So instead we use the reset controller API.
>
> I am good with this patchset.  The only thing I'd like so see modified is the
> above changelog.  The second paragraph doesn't belong there, i.e it is not
> useful to remark on a design that was not accepted.  Instead please concentrate
> on _why_ we are moving from the current design to using the reset controller
> API.
>
> This can go in the 6.15 merge window if you send me a V5 fast enough.

Thanks for review. Reworded the commit message and send V5.

Thanks,
Daniel.