linux-kernel - Re: [PATCH net-next v2 0/8] enic:enable 32, 64 byte cqes and get max rx/tx ring size from hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <978a9d2c-b82c-4209-ba95-8674b149294a@redhat.com>
Date: Tue, 11 Mar 2025 10:25:09 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Simon Horman <horms@...nel.org>, satishkh@...co.com
Cc: Christian Benvenuti <benve@...co.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 Nelson Escobar <neescoba@...co.com>, John Daley <johndale@...co.com>
Subject: Re: [PATCH net-next v2 0/8] enic:enable 32, 64 byte cqes and get max
 rx/tx ring size from hw

On 3/6/25 3:56 PM, Simon Horman wrote:
> On Tue, Mar 04, 2025 at 07:56:36PM -0500, Satish Kharat via B4 Relay wrote:
>> This series enables using the max rx and tx ring sizes read from hw.
>> For newer hw that can be up to 16k entries. This requires bigger
>> completion entries for rx queues. This series enables the use of the
>> 32 and 64 byte completion queues entries for enic rx queues on
>> supported hw versions. This is in addition to the exiting (default)
>> 16 byte rx cqes.
>>
>> Signed-off-by: Satish Kharat <satishkh@...co.com>
>> ---
>> Changes in v2:
>> - Added net-next to the subject line.
>> - Removed inlines from function defs in .c file.
>> - Fixed function local variable style issues.
>> - Added couple of helper functions to common code.
>> - Fixed checkpatch errors and warnings.
>> - Link to v1: https://lore.kernel.org/r/20250227-enic_cleanup_and_ext_cq-v1-0-c314f95812bb@cisco.com
>>
>> ---
>> Satish Kharat (8):
>>       enic: Move function from header file to c file
>>       enic: enic rq code reorg
>>       enic: enic rq extended cq defines
>>       enic: enable rq extended cq support
>>       enic : remove unused function cq_enet_wq_desc_dec
>>       enic : added enic_wq.c and enic_wq.h
>>       enic : cleanup of enic wq request completion path
>>       enic : get max rq & wq entries supported by hw, 16K queues
> 
> nit: please consistently use "enic: " as the subject prefix for
>      the cover-letter and all patches in this patch-set.

Since it looks otherwise good to me, I'll adjust the above while
applying the patches.

Thanks,

Paolo