linux-kernel - Re: [PATCH 2/5] iio: adc: ad4030: remove some duplicate code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2faccc64193c7a6e3585bfbd5a91a1968d0fe8da.camel@gmail.com>
Date: Tue, 11 Mar 2025 09:27:10 +0000
From: Nuno Sá <noname.nuno@...il.com>
To: David Lechner <dlechner@...libre.com>, Lars-Peter Clausen
 <lars@...afoo.de>,  Michael Hennerich <Michael.Hennerich@...log.com>, Nuno
 Sá <nuno.sa@...log.com>, Esteban Blanc	
 <eblanc@...libre.com>, Jonathan Cameron <jic23@...nel.org>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] iio: adc: ad4030: remove some duplicate code

On Mon, 2025-03-10 at 15:43 -0500, David Lechner wrote:
> Remove some duplicate code in the ad4030_get_chan_scale() function by
> simplifying the if statement.
> 
> Signed-off-by: David Lechner <dlechner@...libre.com>
> ---

Reviewed-by: Nuno Sá <nuno.sa@...log.com>

>  drivers/iio/adc/ad4030.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad4030.c b/drivers/iio/adc/ad4030.c
> index
> af7a817e8273496e8856a5ba1a9c2e66a11f0a84..f24b46164a477f9b6b5c93ffeba0a335f7b3
> de5a 100644
> --- a/drivers/iio/adc/ad4030.c
> +++ b/drivers/iio/adc/ad4030.c
> @@ -394,14 +394,13 @@ static int ad4030_get_chan_scale(struct iio_dev
> *indio_dev,
>  	if (IS_ERR(scan_type))
>  		return PTR_ERR(scan_type);
>  
> -	if (chan->differential) {
> +	if (chan->differential)
>  		*val = (st->vref_uv * 2) / MILLI;
> -		*val2 = scan_type->realbits;
> -		return IIO_VAL_FRACTIONAL_LOG2;
> -	}
> +	else
> +		*val = st->vref_uv / MILLI;
>  
> -	*val = st->vref_uv / MILLI;
>  	*val2 = scan_type->realbits;
> +
>  	return IIO_VAL_FRACTIONAL_LOG2;
>  }
>  
>