linux-kernel - Re: [PATCHv4 net 1/2] bonding: fix incorrect MAC address setting to receive NS messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250311093431.GH4159220@kernel.org>
Date: Tue, 11 Mar 2025 10:34:31 +0100
From: Simon Horman <horms@...nel.org>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, Jay Vosburgh <jv@...sburgh.net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Nikolay Aleksandrov <razor@...ckwall.org>,
	Shuah Khan <shuah@...nel.org>, Cosmin Ratiu <cratiu@...dia.com>,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv4 net 1/2] bonding: fix incorrect MAC address setting to
 receive NS messages

On Thu, Mar 06, 2025 at 02:39:22AM +0000, Hangbin Liu wrote:
> When validation on the backup slave is enabled, we need to validate the
> Neighbor Solicitation (NS) messages received on the backup slave. To
> receive these messages, the correct destination MAC address must be added
> to the slave. However, the target in bonding is a unicast address, which
> we cannot use directly. Instead, we should first convert it to a
> Solicited-Node Multicast Address and then derive the corresponding MAC
> address.
> 
> Fix the incorrect MAC address setting on both slave_set_ns_maddr() and
> slave_set_ns_maddrs(). Since the two function names are similar. Add
> some description for the functions. Also only use one mac_addr variable
> in slave_set_ns_maddr() to save some code and logic.
> 
> Fixes: 8eb36164d1a6 ("bonding: add ns target multicast address to slave device")
> Acked-by: Jay Vosburgh <jv@...sburgh.net>
> Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  drivers/net/bonding/bond_options.c | 55 +++++++++++++++++++++++++-----
>  1 file changed, 47 insertions(+), 8 deletions(-)

Reviewed-by: Simon Horman <horms@...nel.org>