linux-kernel - Re: [PATCH v11 3/7] dt-bindings: PCI: qcom: Use sdx55 reg description for ipq9574

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff074197-8d2c-4f76-a4c1-8d91c8cdd821@kernel.org>
Date: Tue, 11 Mar 2025 10:52:28 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com,
 manivannan.sadhasivam@...aro.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, vkoul@...nel.org, kishon@...nel.org,
 andersson@...nel.org, konradybcio@...nel.org, p.zabel@...gutronix.de,
 quic_nsekar@...cinc.com, dmitry.baryshkov@...aro.org,
 linux-arm-msm@...r.kernel.org, linux-pci@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-phy@...ts.infradead.org
Subject: Re: [PATCH v11 3/7] dt-bindings: PCI: qcom: Use sdx55 reg description
 for ipq9574

On 11/03/2025 09:16, Varadarajan Narayanan wrote:
>> I don't understand what is duplication of something here.
> 
> By duplication, I meant the same set of reg-names (in different order).
> 
>>> 	if (adding mhi to ipq9574 reg-names != duplication)
>>>
>>> 		/* Keep existing order */
>>>
>>> 		* Append "mhi" to ipq9574
>>
>> ipq9574 does not have mhi, does it?
> 
> ipq9574 also has it.

Current binding says no, so something is missing.

> 
>> If it has, it should be separate patch with its own explanation of the
>> hardware.
> 
> Will discard these patches from the patchset -
> 
> 	dt-bindings: PCI: qcom: Use sdx55 reg description for ipq9574 Varadarajan Narayanan
> 	arm64: dts: qcom: ipq9574: Reorder reg and reg-names Varadarajan Narayanan
> 
> Will add mhi for ipq9574 and post the next version. Is that ok?

Yes.

Best regards,
Krzysztof