linux-kernel - RE: [PATCH] PCI: xilinx-cpm: Fix incorrect version check in init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SN7PR12MB720164A0B40D1EB3DE4822AF8BD12@SN7PR12MB7201.namprd12.prod.outlook.com>
Date: Tue, 11 Mar 2025 09:58:44 +0000
From: "Havalige, Thippeswamy" <thippeswamy.havalige@....com>
To: Krzysztof Wilczyński <kw@...ux.com>
CC: "bhelgaas@...gle.com" <bhelgaas@...gle.com>, "lpieralisi@...nel.org"
	<lpieralisi@...nel.org>, "manivannan.sadhasivam@...aro.org"
	<manivannan.sadhasivam@...aro.org>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Simek, Michal" <michal.simek@....com>,
	"Gogada, Bharat Kumar" <bharat.kumar.gogada@....com>
Subject: RE: [PATCH] PCI: xilinx-cpm: Fix incorrect version check in init_port

[AMD Official Use Only - AMD Internal Distribution Only]

Hello,

Thank you.

Regards,
Thippeswamy H

> -----Original Message-----
> From: Krzysztof Wilczyński <kw@...ux.com>
> Sent: Tuesday, March 11, 2025 12:58 PM
> To: Havalige, Thippeswamy <thippeswamy.havalige@....com>
> Cc: bhelgaas@...gle.com; lpieralisi@...nel.org;
> manivannan.sadhasivam@...aro.org; robh@...nel.org; krzk+dt@...nel.org;
> conor+dt@...nel.org; linux-pci@...r.kernel.org; devicetree@...r.kernel.org;
> linux-kernel@...r.kernel.org; Simek, Michal <michal.simek@....com>;
> Gogada, Bharat Kumar <bharat.kumar.gogada@....com>
> Subject: Re: [PATCH] PCI: xilinx-cpm: Fix incorrect version check in init_port
>
> Hello,
>
> > Fix an incorrect conditional check in xilinx_cpm_pcie_init_port().
> >
> > The previous condition mistakenly skipped initialization for all
> > versions except CPM5NC_HOST. This is now corrected to ensure that only
> > the CPM5NC_HOST is skipped while other versions proceed with
> > initialization.
>
> [...]
> >  {
> >     const struct xilinx_cpm_variant *variant = port->variant;
> >
> > -   if (variant->version != CPM5NC_HOST)
> > +   if (variant->version == CPM5NC_HOST)
> >             return;
> >
> >     if (cpm_pcie_link_up(port))
>
> Ouch!  Nice catch.
>
> I will pull and squash this against the existing code directly on the branch.
>
> Thank you!
>
>       Krzysztof